Hydration #38
Hydration #38
Conversation
|
I would appreciate it if we could avoid major refactors. It makes it difficult to audit what has actually changed. |
ok, moved only refactoring changes to #39 |
|
My suggestion is to work on adding hydration with the minimal number of changes necessary to the existing code, written in the style of the existing code. A useful new feature should not be predicated on a largely unnecessary and opinionated refactoring. I understand these opinions, and I appreciate the reasoning behind them, but it is very unlikely that I'm going to merge that PR. I do not want to reformat, rewrite, and refactor for the sake of it. |
…2 String DOM.Element PropValue` to `Fn.Fn2 String DOM.Element (Nullable PropValue)`
|
I have reverted #b385b50 in commit c17301b |
…om during hydration (this pr matches test in srghma/purescript-halogen-nextjs@63a9401)
… during hydration
|
@natefaubion @thomashoneyman @garyb The pr is ready it is in sync with purescript-halogen/purescript-halogen#671 I have tested it using this project https://github.com/srghma/purescript-halogen-nextjs/ that is using a copy of examples from halogen, plus additional ones (DeepNesting and TextNodes) The pr in halogen is using next-6 branch, but all latest changes from master are merged in there |
…different from attribute -> handle
…l to "HTTP://WWW.W3.ORG/2000/FOOOOO:SVGFOOP", but got "SVGFOOP" (check warning above for more information)"
…ibuteNames (check warning above for more information)
Error info:
element: "viewBox"
extraAttributeNames: Set(1) {"viewbox"}
Reason:
I misunderstood https://github.com/facebook/react/blob/823dc581fea8814a904579e85a62da6d18258830/packages/react-dom/src/client/ReactDOMComponent.js#L1030
the names are not really lowercased when they are added to a Set
|
@srghma |
no, it will throw error IF dom doesnt match vdom in future would be good to do this check in development, but omit in production
yes, and also split text nodes ( |
fixes #37
WIP