Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re:Hydration #54

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

purefunctor
Copy link
Collaborator

@purefunctor purefunctor commented Jun 15, 2024

Closes #37 and #38. This picks up on the awesome work done by @srghma on #38 with the goal of producing a smaller diff.

TODO

  • Automated tests with with spec and spec-mocha
    • Implement basic VDom "library"
    • Implement VDom to string rendering
    • Implement driver for the hydration machine

cc: @garyb @natefaubion

purefunctor and others added 10 commits June 15, 2024 13:46
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
Co-Authored-By: Serhii Khoma <srghma@gmail.com>
This puts the various xProp functions inside buildProp at the
module level to prepare for code-sharing with the hydrateProp
implementation.

Co-Authored-By: Serhii Khoma <srghma@gmail.com>
@purefunctor
Copy link
Collaborator Author

Up to 83b8772, the changes have been relatively simple as a lot of the shared code between rendering/hydration already exists at the module level.

What's a little more difficult is implementing Prop.purs, since it involves hoisting up functions that are inside of buildProp, which is what I'll be doing in the following commits before going ahead and implementing hydrateProp. I reckon it could also use a refactoring once there's more concrete tests so stuff won't break unexpectedly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydration
1 participant