Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add various comments throughout the code, change argument/type names to more descriptive, add explicit types #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

srghma
Copy link

@srghma srghma commented May 13, 2020

just various comments while I was learning a code

I think non-ideal comment is better than no comments at all

…ype names to more descriptive, add explicit types
@srghma srghma mentioned this pull request May 13, 2020
@srghma
Copy link
Author

srghma commented May 15, 2020

answer on #38 (comment)

ok, I agree that it's not good to change the name of arguments on this stage

but what about:

  • adding types
  • adding comments
  • adding data STObject' which is like STObject but without region argument (allows to add types to some function, before it complained about escaped scolems)

@srghma
Copy link
Author

srghma commented May 16, 2020

I have noticed @thomashoneyman mentioned that during halogen v5 refactoring the

The type variables have been renamed to full words in the component / query / etc. type signatures. Maybe this will help, maybe not - feedback is welcome and appreciated!

maybe longer type variables are not so bad idea

@srghma
Copy link
Author

srghma commented May 16, 2020

also, halogen is using long arrows everywhere ->, halogen-vdom is using unicode arrows everywhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant