Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow a custom provider to be passed to Connect methods #326

Merged
merged 7 commits into from
Jul 26, 2023

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Jul 18, 2023

This PR was published to npm with the alpha versions:

  • connect npm install @stacks/connect@7.3.2-alpha.111be12.0 --save-exact
  • connect-react npm install @stacks/connect-react@22.1.2-alpha.111be12.0 --save-exact
  • connect-ui npm install @stacks/connect-ui@6.1.2-alpha.111be12.0 --save-exact

Description

Allow a custom StacksProvider object to be passed into most Connect methods.

Example

import { authenticate } from '@stacks/connect';

// This will open only the Hiro Wallet
authenticate({ ...normalAuthOptions }, HiroWalletProvider); // <---

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

@janniks janniks requested a review from kyranjamie July 18, 2023 08:57
@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2023

⚠️ No Changeset found

Latest commit: 111be12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
connect-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2023 7:07pm

Copy link
Contributor

@kyranjamie kyranjamie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @janniks

@janniks janniks force-pushed the feat/add-custom-provider-passing branch from b734f01 to 111be12 Compare July 25, 2023 19:06
@janniks janniks merged commit 201455a into main Jul 26, 2023
5 checks passed
@janniks janniks deleted the feat/add-custom-provider-passing branch July 26, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Resolve StacksProvider conflict across wallets
2 participants