-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve StacksProvider conflict across wallets #325
Comments
💯 I'd like to see Connect try to implement a |
+1! Would like to be able to trigger a specific wallet extension (ie: Hiro) when performing actions such as PSBT + message signing! |
I think we could add a quick fix to allow web devs to target a specific wallet using connect. Basically let most functions take in the provider directly, rather than guessing/taking the main one |
1st pass to allow web apps to pass a known stacks provider (up to them to select the one they want etc.) #326 |
Reproducible across all the major Ordinals Marketplaces! |
@RobertClarke Might your team want to try integrating the branch here to confirm it works on your end pre-release? #326 |
Reopening this for further improvements. The first pass fixed #320 |
Curious which improvements you have in mind, and whether we should hold off asking developers to upgrade their integrations or is that effort good to go with the first pass? |
Would like to test out a .provider interface where wallets register their presence and connect would use it to allow users to select their choice and route requests to the custom provider. |
I am implementing Stack/Connect to allow my users to connect either with Hiro or Xverse, to avoid the integration of several libraries, I only use this one. For once Hiro it's easy I push HiroWalletProvider in showConnect on the other hand for xverse I have explored windows in vain I can't find a specific provider for it. For once, send you what as info for xverse? |
cc @m-aboelenein is Xverse thinking about adding a similar custom provider? Maybe we should discuss this in the wallet api standards group? |
|
@fess-v feel free to leave you ideas here as well. Curious to hear all sides 🙂 |
Hello @ThomAille in the latest version of xverse we have added a custom provider you can find it under |
Closed by #341 |
Currently wallets that use
StacksProvider
such as Hiro and Xverse experience collisions whenever both are installed and using apps that have integrated Connect since the library doesn't have a way to distinguish between each wallet when the user wants to perform actions with them (e.g. connect, transact).Developers and users alike would benefit from having the library distinguish them somehow so that only the wallet of choice is incurred for the particular app session, even if multiple remain installed and activated.
Hiro exposes
HiroWalletProvider
as well which may be helpful for supporting such an enhancement.The text was updated successfully, but these errors were encountered: