Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabling wallet extension doesn't register on website until refresh #4064

Closed
whoabuddy opened this issue Jul 26, 2023 · 6 comments · Fixed by #4068
Closed

Enabling wallet extension doesn't register on website until refresh #4064

whoabuddy opened this issue Jul 26, 2023 · 6 comments · Fixed by #4068
Labels
bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds

Comments

@whoabuddy
Copy link

Background

I use both the Hiro wallet and Xverse wallet extension in my browser. Both are set to only allow usage on a website when the extension is clicked on.

This occurred for me today on two Stacks websites that I use regularly, not sure if it's related to the latest version or if it's a downstream issue with Stacks.js/micro-stacks.

Figured I'd start here first since I am not seeing the same issue with Xverse wallet - it still works as expected.

Expected flow

  1. Click to login on website - receive error no wallet installed
  2. Click to enable wallet extension
  3. Click to login on website - successful pop-up
  4. Continue per usual

What happens now

  1. Click to login on website - receive error no wallet installed
  2. Click to enable wallet extension
  3. Click to login on website - receive error no wallet installed
  4. Refresh website
  5. Click to login on website - successful pop-up
  6. Continue per usual
@markmhendrickson
Copy link
Collaborator

Did this change in behavior happen about a week ago? We pushed live support for Manifest v3 which may have caused an underlying change in behavior here re: how the extension gets recognized upon activation.

Also note that work has been going on to resolve these collisions so you don't have to deactivate and reactivate:

hirosystems/connect#326
secretkeylabs/sats-connect#14

@markmhendrickson markmhendrickson changed the title Enabling wallet extension doesn't register on website Enabling wallet extension doesn't register on website until refresh Jul 27, 2023
@whoabuddy
Copy link
Author

Possibly, although I think I would've noticed it right away based on a few things I'm working on.

On my laptop I still had 5.0.0 (slow auto-update, or intermittent connection maybe?) and it worked as expected.

Working around it for now with a refresh but great to hear there's progress on the provider collisions!

I actually prefer to keep the extension on click to activate so I'm not turning it on unless I plan to use it.

@markmhendrickson markmhendrickson added bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds labels Jul 28, 2023
@markmhendrickson
Copy link
Collaborator

It looks like @kyranjamie may have just resolved this issue here? #4068

@markmhendrickson markmhendrickson linked a pull request Jul 31, 2023 that will close this issue
fix: firefox manually loaded extension #4068
Merged
@markmhendrickson
Copy link
Collaborator

Just to confirm, were you using Firefox or Chrome?

@whoabuddy
Copy link
Author

Chrome/Brave

@whoabuddy
Copy link
Author

I'm using 6.2.1 and the behavior is working as expected again! If I click to enable I no longer have to refresh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Functionality broken bug-p4 Non-critical functionality broken for few users, or there are clear workarounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: firefox manually loaded extension leather-io/extension
3 participants
@markmhendrickson @kyranjamie @whoabuddy