v0.3.0 #7
v0.3.0 #7
Conversation
|
Just letting you know btw, Math.cos and Math.sin are ever so slightly faster than their MathHelper variants, even when they're casted to another variable |
|
Hello, thank your for actually contributing to Make Bubbles Pop! |
Thanks, I didn't know that |
|
Yeah same here college kinda sucks |
|
actually im gonna luna-fy the mod lol (or aviewfromthetop-ify) |
|
ohh, nice! |
|
Actually, I like the pop bubbles not retaining their velocity more as well... maybe I'll just ditch the option |
- Fixed maintain velocity option not having an effect - Made BarrelEntityOnUse an abstract class - Added OnlyIn annotation in BarrelBubbler on Forge - Added comments
I unfortunately know literally nothing about Forge other than how to register some things lol |
|
Damn, rip |
- Tweaked explosion bubbles and used better variable names - Updated GitHub workflow - Updated CurseForge badge in README - Added CurseForge direct messages as a way of contacting me in the LICENSE
- Added a config file and menu when installed alongside MidnightLib (closes Tschipcraft#4) - Restructured bubble particle logic and used better variable types - Added experimental multiplayer support for barrel bubbles (even on Forge - Tschipcraft#11) - Adjusted barrel bubble spawn locations - Updated GitHub workflow to upload build artifacts
- Adjusted current down bubbles to pop on the top of magma blocks rather than inside them (closes Tschipcraft#9) - Fixed barrel bubbles not appearing outside the dev environment on forge (Tschipcraft#11) - Added alt texts to images in README - Updated GitHub workflow to use setup-gradle caching instead
|
@Tschipcraft is it ok if I change the mod version to 1.20.1 and add FrozenLib+Cloth Config config compat to this? Edit: I just remembered I only know how to do Fabric stuff |
That should work, I kinda forgot you could call for the MC version- |
I found out about Make Bubbles Pop a couple months after I added it lmao |
Ah well, it's a pretty common idea, Effective also added chest bubbling after myself a while ago |
|
Btw, any particular reasons why you switched from storing block positions to block entities in the array list in the barrel bubbles, and why from an override to an inject that cancels the method in BubblePop, wouldn't a redirect be better if overrides should be avoided? |
It prevents block entities from other dimensions potentially bubbling (though im not 100% but it’s just to be safe) |
- Added biome dependent tint to all bubble types, including config entries to control intensity and enablement of this feature - Moved bubble pop logic to a global utility class to reduce code duplication - Added varied bubble pop volume (closes Tschipcraft#8)
- Reordered and reformatted config entries - Added tooltips when hovering over config entries - Added option to disable bubble swirl sound playing when opening chests or barrels underwater - Updated GitHub workflow
|
I tested this out a bit, saving only the BlockPos does prevent containers in other dimensions in the same location to bubble, at least from my testing. I'm gonna change this back to be consistent with the Forge version, solely because saving the BlockPos there is easier lol |
- Fixed some players affecting bubbles when returning a high upwards y velocity despite standing still (They return the constant y velocity of 0.419875. This seems to happen to players if they have been flying in creative mode before while loaded on the client) - Reverted to saving only block positions for barrel bubbles on Fabric for consistency with the Forge version
- Fixed literal new line in fabric.mod.json after building (closes Tschipcraft#12) - Fixed opened double chests playing bubble swirl sound even if it's turned off in the config - Simplified water checks to use the already provided helper function in world or level - Added varied volume and pitch to bubble swirl sound when opening containers - Reworded some config entries and log output - Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+ - Updated mappings - Increased pack format to 41 for mc1.20.5
|
This weirdly fixes 1.20.5/6 support. Cannot identify any bugs since the latest changes you've made 3 months ago with a performance-based modpack. |
|
I mean yeah, v0.3.0 is basically done. I just need to backport it to pre 1.19.4 versions still. I'll have time in approx. 1 month when the semester ends |
|
Works fine even in 1.21 version |
|
My apologies for not contributing for a while, life got in the way and I’ve been working on lots of bugfixes for Wilder Wild. |
|
Ya, no worries. I know the feeling. I want to push out v0.3.0 in the next few weeks before any new features, since it's been almost a year since the last update, but after that I'd still be interested in the FLib integration (and/or any other additions/fixes). Oh and again thanks for contributing in the first place <3 |
Forge version sadly doesn't work in 1.21 yet Edit: Works now |
- Added config file and settings menu when installed alongside MidnightLib (#4) - Added entity interaction physics to bubbles - Added biome dependent tint to all bubble types - Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop) - Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9) - Added varied pitch and volume to bubble pop and bubble swirl sounds (#8) - Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop) - Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop) - Tweaked explosion bubbles and used better variable names - Restructured bubble particle logic and used better variable types - Adjusted barrel bubble spawn locations - Moved bubble pop logic to a separate utility class to reduce code duplication - Simplified water checks to use the already provided helper function in world or level - Fixed literal new line in fabric.mod.json after building (#12) - Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
- Added config file and settings menu when installed alongside MidnightLib (#4) - Added entity interaction physics to bubbles - Added biome dependent tint to all bubble types - Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop) - Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9) - Added varied pitch and volume to bubble pop and bubble swirl sounds (#8) - Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop) - Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop) - Tweaked explosion bubbles and used better variable names - Restructured bubble particle logic and used better variable types - Adjusted barrel bubble spawn locations - Moved bubble pop logic to a separate utility class to reduce code duplication - Simplified water checks to use the already provided helper function in world or level - Fixed literal new line in fabric.mod.json after building (#12) - Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
- Added media for changelog - Updated version range for forge - Updated GitHub workflow to include version range
If anything else is needed or if you want me to try adding anything else, just let me know
I'm open to this PR being edited as well, it's just a basis for compat with Wilder Wild and Particle Tweaks
CURRENT CHANGES (edited by @Tschipcraft):