Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Barrels opened by other players don't spawn bubbles #11

Closed
YoshiRulz opened this issue Feb 8, 2024 · 1 comment · Fixed by #7
Closed

Barrels opened by other players don't spawn bubbles #11

YoshiRulz opened this issue Feb 8, 2024 · 1 comment · Fixed by #7
Assignees
@Tschipcraft
Labels
bug Something isn't working

Comments

@YoshiRulz
Copy link

Describe the bug

Opening chests or barrels creates bubbles. Watching another player open a chest, I see bubbles, but not with a barrel.

Steps to reproduce

  1. Be in multiplayer
  2. Place barrel
  3. Have friend click barrel

Expected behavior

bubble

Additional context

Using version 0.2.0 of the mod for Fabric on MC 1.20.4.
@YoshiRulz YoshiRulz added the bug Something isn't working label Feb 8, 2024
@Tschipcraft
Copy link
Owner

Tschipcraft commented Feb 8, 2024 •
edited
Loading

This is a known issue. AViewFromTheTop has already figured out a solution for the Fabric version (see #7), but I have no idea how to implement this in Forge since it requires custom network packets. It will be in the next release as a Fabric exclusive feature I guess..

Edit: I found a different way to implement this in Forge by registering a clientTick method for the BarrelBlock

@Tschipcraft Tschipcraft linked a pull request Feb 8, 2024 that will close this issue
v0.3.0 #7
Merged
Tschipcraft added a commit to AViewFromTheTop/make_bubbles_pop that referenced this issue Feb 17, 2024
@Tschipcraft
Add config file and menu
c16e69b 
- Added a config file and menu when installed alongside MidnightLib (closes Tschipcraft#4)
- Restructured bubble particle logic and used better variable types
- Added experimental multiplayer support for barrel bubbles (even on Forge - Tschipcraft#11)
- Adjusted barrel bubble spawn locations
- Updated GitHub workflow to upload build artifacts
@Tschipcraft Tschipcraft self-assigned this Feb 17, 2024
Tschipcraft added a commit to AViewFromTheTop/make_bubbles_pop that referenced this issue Feb 18, 2024
@Tschipcraft
Adjust current down bubbles
9ca21d8 
- Adjusted current down bubbles to pop on the top of magma blocks rather than inside them (closes Tschipcraft#9)
- Fixed barrel bubbles not appearing outside the dev environment on forge (Tschipcraft#11)
- Added alt texts to images in README
- Updated GitHub workflow to use setup-gradle caching instead
@Tschipcraft Tschipcraft mentioned this issue Jul 11, 2024
Merged
Tschipcraft added a commit that referenced this issue Jul 11, 2024
@Tschipcraft
Backport v0.3.0 (#7)
3c426c5 
- Added config file and settings menu when installed alongside MidnightLib (#4)
- Added entity interaction physics to bubbles
- Added biome dependent tint to all bubble types
- Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop)
- Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9)
- Added varied pitch and volume to bubble pop and bubble swirl sounds (#8)
- Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop)
- Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop)
- Tweaked explosion bubbles and used better variable names
- Restructured bubble particle logic and used better variable types
- Adjusted barrel bubble spawn locations
- Moved bubble pop logic to a separate utility class to reduce code duplication
- Simplified water checks to use the already provided helper function in world or level
- Fixed literal new line in fabric.mod.json after building (#12)
- Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
Tschipcraft added a commit that referenced this issue Jul 11, 2024
@Tschipcraft
Backport v0.3.0 (#7)
0c29d53 
- Added config file and settings menu when installed alongside MidnightLib (#4)
- Added entity interaction physics to bubbles
- Added biome dependent tint to all bubble types
- Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop)
- Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9)
- Added varied pitch and volume to bubble pop and bubble swirl sounds (#8)
- Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop)
- Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop)
- Tweaked explosion bubbles and used better variable names
- Restructured bubble particle logic and used better variable types
- Adjusted barrel bubble spawn locations
- Moved bubble pop logic to a separate utility class to reduce code duplication
- Simplified water checks to use the already provided helper function in world or level
- Fixed literal new line in fabric.mod.json after building (#12)
- Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tschipcraft Tschipcraft

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v0.3.0 AViewFromTheTop/make_bubbles_pop
2 participants
@YoshiRulz @Tschipcraft