Magma block bubble column appears to pop inside the block rather than on the top #9
Assignees
Labels
feature request
New feature or request
Comments
|
Thank you for the great suggestion, now that you mentioned it I'm bothered by it as well. This will be implemented in a future update! |
|
This is the current progress. What do you think @YoshiRulz? Make.Bubbles.Pop.comparison.3.mp4 |
|
Looks great! |
Merged
Merged
Tschipcraft
added a commit
that referenced
this issue
Jul 11, 2024
- Added config file and settings menu when installed alongside MidnightLib (#4) - Added entity interaction physics to bubbles - Added biome dependent tint to all bubble types - Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop) - Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9) - Added varied pitch and volume to bubble pop and bubble swirl sounds (#8) - Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop) - Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop) - Tweaked explosion bubbles and used better variable names - Restructured bubble particle logic and used better variable types - Adjusted barrel bubble spawn locations - Moved bubble pop logic to a separate utility class to reduce code duplication - Simplified water checks to use the already provided helper function in world or level - Fixed literal new line in fabric.mod.json after building (#12) - Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
Tschipcraft
added a commit
that referenced
this issue
Jul 11, 2024
- Added config file and settings menu when installed alongside MidnightLib (#4) - Added entity interaction physics to bubbles - Added biome dependent tint to all bubble types - Fixed barrels opened by other players on servers not emitting bubbles (#11) (Thanks @AViewFromTheTop) - Adjusted current down bubbles to pop on top of magma blocks rather than inside them (#9) - Added varied pitch and volume to bubble pop and bubble swirl sounds (#8) - Barrel bubbling is now reliable on the client and will no longer bubble when a chunk with an already opened Barrel is loaded (Thanks @AViewFromTheTop) - Changed the default behavior to not maintain bubble particle velocity when popping (Thanks @AViewFromTheTop) - Tweaked explosion bubbles and used better variable names - Restructured bubble particle logic and used better variable types - Adjusted barrel bubble spawn locations - Moved bubble pop logic to a separate utility class to reduce code duplication - Simplified water checks to use the already provided helper function in world or level - Fixed literal new line in fabric.mod.json after building (#12) - Updated to Gradle 8.7, Loom 1.6 and ForgeGradle 6.+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Title. This isn't the fault of the mod, it also happens in vanilla (the bubbles blink out of existence halfway inside the block).
Describe the feature you'd like
Either adjusting the bubbles' target Y if possible, or collision detection.
Describe alternatives you've considered
No response
Additional context
Using version 0.2.0 of the mod for Fabric on MC 1.20.4.
The text was updated successfully, but these errors were encountered: