@pypi and faster @conda #1505
@pypi and faster @conda #1505
Conversation
savingoyal
force-pushed
the
pip-decorator
branch
from
8508764
to
cd78065
Compare
|
All test failures are due to a (un)related issue with how we vendor packages. |
savingoyal
force-pushed
the
pip-decorator
branch
from
de5cdfa
to
7ed6ebf
Compare
saikonen
dismissed
their stale review
butterfingered approval, will still run through some tests but changes I requested are ok :)
| # Create Conda environment. | ||
| cmds = [ | ||
| # TODO: check if mamba or conda are already available on the image | ||
| f"""if ! command -v ./micromamba >/dev/null 2>&1; then |
There was a problem hiding this comment.
why just in current dir?
There was a problem hiding this comment.
OK. I think I finished looking at it. It's mostly minor stuff. I think the pinned dep stuff warrants fixing since I don't see a compelling reason to change it (unless I am missing something). It feels gratuitous to break something that people may be relying on (as you say, if it's in the code :) ).
There is some concern around the general way things are done in a not very multiple-process safe kind of way (even removing some of the previous locks that were in the previous implementation) so I suspect that we will hit some issues there at some point but it probably won't impact users directly as it is not very common.
|
#1567 re-enables pinned_conda_libs. re - removing the locks - it shouldn't be an issue anymore. Dangling lock files were a big headache in the previous implementation - now everything happens in a multi-process safe manner - so we should be good. |
To try it out