Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@pypi and faster @conda #1505

Merged
merged 47 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from 45 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
7fb3cdf
@pip draft
savingoyal Jun 19, 2023
51870ae
chore: pip deco fixes (#1523)
saikonen Sep 7, 2023
b3eeb48
add support for legacy libraries= in conda decorator (#1525)
saikonen Sep 10, 2023
e9aa328
chore: fix micromamba detection (#1526)
saikonen Sep 10, 2023
d37ffd1
@pip draft
savingoyal Jun 19, 2023
e8c2d79
vend
savingoyal Sep 10, 2023
170e51c
rebase
savingoyal Sep 10, 2023
74b98bf
more changes
savingoyal Sep 10, 2023
ace161a
more changes
savingoyal Sep 10, 2023
e391630
enable conda channels
savingoyal Sep 10, 2023
78c7b7e
more comments
savingoyal Sep 10, 2023
35ab0e3
introduce conda_base
savingoyal Sep 10, 2023
0c589c9
more changes
savingoyal Sep 10, 2023
f3cc8e9
address comments
savingoyal Sep 10, 2023
a3ecf94
address nousersite issue
savingoyal Sep 10, 2023
fea4995
handle cross-platform cache check optimization
savingoyal Sep 11, 2023
c264a44
handle missing tarballs
savingoyal Sep 11, 2023
5a53102
update comments
savingoyal Sep 11, 2023
3841f4c
fix biug
savingoyal Sep 11, 2023
acd99f3
address more todos
savingoyal Sep 11, 2023
f002efd
remove stray file
savingoyal Sep 11, 2023
f422508
fix comments
savingoyal Sep 11, 2023
a0aecc8
fix mac version
savingoyal Sep 12, 2023
57f38c6
fix passing multiple channels (#1536)
saikonen Sep 13, 2023
4c0c866
chore: pip decorator fixes (#1535)
saikonen Sep 13, 2023
1e0a219
conditional import for packaging for python 3.5 (#1534)
saikonen Sep 14, 2023
1eadcd1
fix micromamba download extraction command (#1539)
saikonen Sep 14, 2023
d60796e
support extra indices
savingoyal Sep 27, 2023
d64cb8a
support @pypi(python=)
savingoyal Sep 27, 2023
4dbf8f1
support extensions
savingoyal Sep 27, 2023
faf48d5
support @pypi_base
savingoyal Sep 27, 2023
af4f0f5
more changes
savingoyal Sep 27, 2023
8c5c085
@pypi(disabled=)
savingoyal Sep 28, 2023
60ffda8
fix issue
savingoyal Sep 28, 2023
2ca13d5
fix issue
savingoyal Sep 28, 2023
6467397
fix
savingoyal Sep 28, 2023
40ee7d4
address @ville's issue
savingoyal Sep 28, 2023
933cefa
support extensions
savingoyal Sep 28, 2023
f731864
env escape support
savingoyal Sep 28, 2023
038fea0
fix
savingoyal Sep 28, 2023
4fa9cae
drop pip resolution times by 65%
savingoyal Sep 29, 2023
ebc35bc
fix up INFO
savingoyal Sep 29, 2023
6020afc
cleanup
savingoyal Sep 29, 2023
7ed6ebf
remove spurious todos
savingoyal Oct 3, 2023
e6a6330
address minor nits
savingoyal Oct 4, 2023
ab663f6
remove references to py3.5
savingoyal Oct 4, 2023
8347bd7
add stub object for py3.5
savingoyal Oct 4, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion metaflow/_vendor/vendor_any.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
click==7.1.2
packaging==23.0
packaging==23.0
1 change: 1 addition & 0 deletions metaflow/metaflow_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,7 @@ def get_version(pkg):
return pkg_resources.get_distribution(pkg).version


# TODO: This is no longer in use and can be dispensed with.
# PINNED_CONDA_LIBS are the libraries that metaflow depends on for execution
# and are needed within a conda environment
def get_pinned_conda_libs(python_version, datastore_type):
Expand Down
11 changes: 8 additions & 3 deletions metaflow/plugins/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,11 @@
"unbounded_test_foreach_internal",
".test_unbounded_foreach_decorator.InternalTestUnboundedForeachDecorator",
),
("conda", ".conda.conda_step_decorator.CondaStepDecorator"),
("card", ".cards.card_decorator.CardDecorator"),
("pytorch_parallel", ".frameworks.pytorch.PytorchParallelDecorator"),
("airflow_internal", ".airflow.airflow_decorator.AirflowInternalDecorator"),
("pypi", ".pypi.pypi_decorator.PyPIStepDecorator"),
savingoyal marked this conversation as resolved.
Show resolved Hide resolved
("conda", ".pypi.conda_decorator.CondaStepDecorator"),
]

# Add new flow decorators here
Expand All @@ -53,15 +54,19 @@
# careful with the choice of name though - they become top-level
# imports from the metaflow package.
FLOW_DECORATORS_DESC = [
("conda_base", ".conda.conda_flow_decorator.CondaFlowDecorator"),
("schedule", ".aws.step_functions.schedule_decorator.ScheduleDecorator"),
("project", ".project_decorator.ProjectDecorator"),
("trigger", ".events_decorator.TriggerDecorator"),
("trigger_on_finish", ".events_decorator.TriggerOnFinishDecorator"),
("pypi_base", ".pypi.pypi_decorator.PyPIFlowDecorator"),
("conda_base", ".pypi.conda_decorator.CondaFlowDecorator"),
]

# Add environments here
ENVIRONMENTS_DESC = [("conda", ".conda.conda_environment.CondaEnvironment")]
ENVIRONMENTS_DESC = [
("conda", ".pypi.conda_environment.CondaEnvironment"),
("pypi", ".pypi.pypi_environment.PyPIEnvironment"),
]

# Add metadata providers here
METADATA_PROVIDERS_DESC = [
Expand Down
90 changes: 0 additions & 90 deletions metaflow/plugins/conda/__init__.py

This file was deleted.

104 changes: 0 additions & 104 deletions metaflow/plugins/conda/batch_bootstrap.py

This file was deleted.

Loading
Loading