Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave conda dependencies floating instead of pinned #399

Closed
savingoyal opened this issue Dec 15, 2020 · 3 comments
Closed

Leave conda dependencies floating instead of pinned #399

savingoyal opened this issue Dec 15, 2020 · 3 comments

Comments

@savingoyal
Copy link
Collaborator

@conda currently pins some dependencies to specific versions (requests, click etc.). This can cause conflict with some other user-defined packages (snowflake-client etc.) which might pin the same packages to a different version. Also, anytime Metaflow updates the package versions, it ends up resolving the user environment again, which is undesirable. We should leave the dependencies floating.

@bishax
Copy link
Contributor

bishax commented Aug 27, 2021

@savingoyal I'm running into this problem on python 3.9 with no deps declared because the pinned version of coverage (4.5.4) isn't available for 3.9 (this means any newcomer on 3.9 trying metaflow with the conda environment will hit an Unsatisfiable environment error!)

$ conda search coverage | grep py39
coverage                         5.3  py39h07f9747_1  conda-forge         
coverage                         5.3  py39h27cfd23_2  pkgs/main           
coverage                         5.3  py39h3811e60_1  conda-forge         
coverage                       5.3.1  py39h27cfd23_2  pkgs/main           
coverage                       5.3.1  py39h3811e60_0  conda-forge         
coverage                       5.3.1  py39h3811e60_1  conda-forge         
coverage                         5.4  py39h27cfd23_2  pkgs/main           
coverage                         5.4  py39h3811e60_0  conda-forge         
coverage                         5.5  py39h27cfd23_2  pkgs/main           
coverage                         5.5  py39h3811e60_0  conda-forge

Minus some formatting and commenting then #411 looks like it would close this issue.
Did it just slip off the backlog or was there a reason for not merging?
If it's the first I can revive that PR (or @rchui can if they'd prefer)?

@rchui
Copy link
Contributor

rchui commented Aug 29, 2021

@bishax The branch fell way behind and slipped off the backlog for the metaflow team. You're welcome to revive it and give it another try.

@savingoyal
Copy link
Collaborator Author

addressed in #1505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants