Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/152 update to v6 #154

Merged
merged 7 commits into from
Oct 3, 2024
Merged

Feature/152 update to v6 #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
98145ca
Don't use default 1 for replicaCount
Hechamon Aug 7, 2024
8be2b72
Update Chart.yaml with new version
Hechamon Aug 7, 2024
634e70d
Merge branch 'master' into master
juanpicado Oct 1, 2024
c4034eb
Merge branch 'master' into master
juanpicado Oct 1, 2024
87e6d1f
Update README.md
Hechamon Oct 2, 2024
359c1c9
Update Chart.yaml
Hechamon Oct 2, 2024
5085e17
Update values.yaml
Hechamon Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ helm install npm verdaccio/verdaccio

```bash
# Helm v3+
helm install npm --set image.tag=5.29.0 verdaccio/verdaccio
helm install npm --set image.tag=6.0.0 verdaccio/verdaccio
```

### Upgrading Verdaccio
Expand Down
4 changes: 2 additions & 2 deletions charts/verdaccio/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
apiVersion: v2
description: A lightweight private node.js proxy registry
name: verdaccio
version: 4.18.0
appVersion: 5.31.1
version: 4.19.0
Copy link
Member

@juanpicado juanpicado Oct 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with this one, since is not a breaking change for Docker, only for npmjs (Docker uses Node.js 20+ by default since a while)

ref: https://github.com/verdaccio/verdaccio/releases/tag/v6.0.0

appVersion: 6.0.0
home: https://verdaccio.org
icon: https://cdn.verdaccio.dev/logos/default.png
sources:
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ metadata:
{{- end }}
spec:
{{- if .Values.replicaCountEnabled }}
replicas: {{ default 1 .Values.replicaCount }}
replicas: {{ .Values.replicaCount }}
{{- end}}
revisionHistoryLimit: {{ .Values.revisionHistoryLimit }}
selector:
Expand Down
2 changes: 1 addition & 1 deletion charts/verdaccio/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
image:
repository: verdaccio/verdaccio
# tag: 5.21.1
# tag: defaults to appVersion in Chart.yaml
pullPolicy: IfNotPresent
pullSecrets: []
# - dockerhub-secret
Expand Down
Loading