Feature/152 update to v6 #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `default` handles 0 (zero) as "not set", it's currently impossible to scale the helm chart to 0 replicas. The default value in the values file is 1 anyways, so this should not cause a breaking change.
Switch to v6 image
update documentation comment in values.yaml
juanpicado
reviewed
Oct 3, 2024
| @@ -1,8 +1,8 @@ | |||
| apiVersion: v2 | |||
| description: A lightweight private node.js proxy registry | |||
| name: verdaccio | |||
| version: 4.18.0 | |||
| appVersion: 5.31.1 | |||
| version: 4.19.0 | |||
There was a problem hiding this comment.
I'd go with this one, since is not a breaking change for Docker, only for npmjs (Docker uses Node.js 20+ by default since a while)
ref: https://github.com/verdaccio/verdaccio/releases/tag/v6.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update versions to 6.0.0 #152