weaken type constraint of "directory" attribute

[XSven]

This should fix the issue #68. For all the classes that have a directory attribute the isa type constraint was changed from Str (belonging to Types::Standard) to Path (belong to Types::Path::Tiny) and coercion was enabled.

[oalders]

Could we add a regression test?

[XSven]

It is not entirely clear to me what you are looking for. Im usually not testing how a class is declared that means in the current case how the isa properties of the attributes are set. What we could do is we could adjust existing tests like for example t/03_inject.t in a way that once we are calling the OrePAN2::Indexer constructor with a Str directory and a second time we are calling the OrePAN2::Indexer constructor with a Path (Path::Tiny) directory. Does this meet your expectation?

[oalders]

Yes, that's exactly it. 😄

[XSven]

Ok this is the first thing I will work on tomorrow morning (Hamburg time).

[oalders]

Alles klar!

[XSven]

The constructor of the class OrePAN2::Repository::Cache wasn't tested explicitly: There is an implicit test because the test code coverage report shows that OrePAN2::Repository::_build_cache() is called and $self->directory from now on returns a Path::Tiny object due to coercion.

The behaviour of the directory() getter method is the only thing that is no longer backwards compatible: Coercion weakens the type constraint on the input side but what you get back is all the time a Path::Tiny object.

[oalders]

The behaviour of the directory() getter method is the only thing that is no longer backwards compatible: Coercion weakens the type constraint on the input side but what you get back is all the time a Path::Tiny object.

We don't anticipate anything breaking with end users, though?

[XSven]

No we don't, although we were already tricked by the fact that Path::Tiny objects were used as values for the directory attribute. From what I know now this is a problem with improper implemenetation encapsulation: The File::Spec::catfile() class method that is used internally by the core OrePAN2 classes, can digest Strings and Path::Tiny objects. I doubt that this design was done on purpose but at least shouldn't have been leaked to the outside.