Path::Tiny object is not coerced/stringified

[oalders]

See metacpan/metacpan-api#1161 (comment) This could use a regression test.

[oalders]

@XSven ^^

[XSven]

Ok I have compared the current master with the commit 1cc2320 (0.49 tag)

git diff 1cc2320 lib/OrePAN2/Injector.pm
diff --git a/lib/OrePAN2/Injector.pm b/lib/OrePAN2/Injector.pm
index 195b50b..aecf2fa 100644
--- a/lib/OrePAN2/Injector.pm
+++ b/lib/OrePAN2/Injector.pm
@@ -1,9 +1,9 @@
 package OrePAN2::Injector;

-use strict;
-use warnings;
 use utf8;

+use Moo;
+
 use Archive::Extract ();
 use Archive::Tar     qw( COMPRESS_GZIP );
 use CPAN::Meta       ();
@@ -16,20 +16,12 @@ use File::Temp       qw( tempdir );
 use File::pushd      qw( pushd );
 use HTTP::Tiny       ();
 use MetaCPAN::Client ();
+use Types::Standard  qw( CodeRef Str );

-sub new {
-    my $class = shift;
-    my %args  = @_ == 1 ? %{ $_[0] } : @_;
-    unless ( exists $args{directory} ) {
-        Carp::croak("Missing directory");
-    }
-    bless {
-        author => 'DUMMY',
-        %args
-    }, $class;
-}
+use namespace::clean;

-sub directory { shift->{directory} }
+has author => ( is => 'ro', isa => CodeRef | Str, default => 'DUMMY' );
+has directory => ( is => 'ro', isa => Str, required => 1 );

 sub inject {
     my ( $self, $source, $opts ) = @_;

I guess my Perl knowledge is not sufficient here, but where in the former (highlighted in red) implementation is the Path::Tiny to String conversion (stringification) happening?
My second question is should we really convert a Path::Tiny object back to a String (stringification) or should we work consistently with Path::Tiny objects as directory values and if necessary do a Str to Path::Tiny coercion.

[oalders]

I don't think the stringification happens in this (red) diff. It would happen when directory gets concatenated with something else.

We could just use https://metacpan.org/pod/Types::Path::Tiny and coerce everything we get into a Path::Tiny object if there's some value in that. Otherwise coerce whatever we get into a string. Probably the former would be a good idea.

[oalders]

Closed via #69