Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

technically improvements part 1 #61

Merged
merged 27 commits into from
Feb 10, 2024
Merged
Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
01919f2
tidy cpanfile too
XSven Nov 29, 2023
50c371c
use Moo to setup Index class
XSven Nov 29, 2023
db78e29
do not pass a File::pushd object to OrePAN2::CLI::Indexer::run()
XSven Nov 29, 2023
a76f18f
use Moo to setup Indexer class
XSven Nov 29, 2023
b41f8f5
add minimal .vimrc file
XSven Nov 30, 2023
7b883db
consistent use of metacpan getter in Indexer class
XSven Nov 30, 2023
06142a4
validate signature of OrePAN2::Indexer::make_index() method
XSven Nov 30, 2023
5b77d75
use Type::Params modern API
XSven Dec 2, 2023
76c172c
use Moo to setup Repository class
XSven Dec 2, 2023
98bad1e
use Moo to setup Injector class
XSven Dec 2, 2023
f52d890
remove perl version check (keep the one in cpanfile)
XSven Dec 4, 2023
01a3548
keep 'version' VERSION check only in cpanfile
XSven Dec 4, 2023
e5fee0c
keep 'Moo' VERSION check only in cpanfile
XSven Dec 4, 2023
5bc4c48
streamline cpanfile layout
XSven Dec 4, 2023
195491e
ignore META.json
XSven Dec 5, 2023
e5dcbc8
use Moo to setup Cache class
XSven Dec 5, 2023
a4582e1
cleanup dependencies (remove Parse::PMFile)
XSven Dec 5, 2023
2f2aac7
do not quote attribute names
XSven Jan 20, 2024
428a2bf
Don't run scheduled builds as eventually the action gets disabled
oalders Jan 10, 2024
4dfe201
Add dependabot config
oalders Jan 10, 2024
7e7ced1
Bump actions/upload-artifact from 3 to 4
dependabot[bot] Jan 10, 2024
3d5ec3d
Bump actions/checkout from 2 to 4
dependabot[bot] Jan 10, 2024
d49beb4
Bump actions/download-artifact from 3 to 4
dependabot[bot] Jan 10, 2024
3f104f4
Bump perl-actions/install-with-cpm from 1.3 to 1.7
dependabot[bot] Jan 10, 2024
282274f
Add 5.38 to builds
oalders Jan 10, 2024
0fa43a2
Fix some typos
oalders Jan 10, 2024
10202f3
Merge branch 'master' into master
oalders Feb 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,4 +31,4 @@ MYMETA.*
/.build
/_build_params
!Build/
!META.json
META.json
1 change: 1 addition & 0 deletions .vimrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
let $PERL5LIB = join( filter( map ( [ 't/lib', 'lib' ], { idx, val -> getcwd() . '/' . val } ), { idx, val -> isdirectory( val ) } ), ':' ) . ':' . $PERL5LIB
124 changes: 0 additions & 124 deletions META.json

This file was deleted.

94 changes: 49 additions & 45 deletions cpanfile
Original file line number Diff line number Diff line change
@@ -1,55 +1,59 @@
use strict;
use warnings;

requires 'perl', '5.012000';
requires 'autodie';
on 'runtime' => sub {
requires 'perl' => '5.012000';
requires 'autodie' => '0';

requires 'Archive::Extract', 0.72;
requires 'Archive::Tar', 1.46;
requires 'CPAN::Meta', 2.131560;
requires 'Class::Accessor::Lite', '0.05';
requires 'Digest::MD5';
requires 'ExtUtils::MakeMaker', '7.06';
requires 'File::Path';
requires 'File::Temp';
requires 'File::pushd';
requires 'Getopt::Long', 2.39;
requires 'HTTP::Tiny';
requires 'IO::File::AtomicChange';
requires 'IO::Socket::SSL', 1.42;
requires 'IO::Uncompress::Gunzip';
requires 'IO::Zlib';
requires 'JSON::PP';
requires 'LWP::UserAgent';
requires 'List::Compare';
requires 'MetaCPAN::Client', '2.000000';
requires 'Moo', '1.007000';
requires 'MooX::Options';
requires 'Parse::CPAN::Meta', '1.4414';
requires 'Parse::CPAN::Packages::Fast', '0.09';
requires 'Parse::LocalDistribution', '0.14';
requires 'Parse::PMFile', '0.29';
requires 'Path::Tiny';
requires 'Pod::Usage';
requires 'Ref::Util';
requires 'Try::Tiny';
requires 'Type::Params';
requires 'Types::URI';
requires 'feature';
requires 'parent';
requires 'version', '0.9912';
requires 'Archive::Extract' => '0.72';
requires 'Archive::Tar' => '1.46';
requires 'CPAN::Meta' => '2.131560';
requires 'Digest::MD5' => '0';
requires 'ExtUtils::MakeMaker' => '7.06';
requires 'File::Path' => '0';
requires 'File::Spec' => '0';
requires 'File::Temp' => '0';
requires 'File::pushd' => '0';
requires 'File::stat' => '0';
requires 'Getopt::Long' => '2.39';
requires 'HTTP::Tiny' => '0';
requires 'IO::File::AtomicChange' => '0';
requires 'IO::Socket::SSL' => '1.42';
requires 'IO::Uncompress::Gunzip' => '0';
requires 'IO::Zlib' => '0';
requires 'JSON::PP' => '0';
requires 'LWP::UserAgent' => '0';
requires 'List::Compare' => '0';
requires 'MetaCPAN::Client' => '2.000000';
requires 'Moo' => '1.007000';
requires 'MooX::Options' => '0';
requires 'MooX::StrictConstructor' => '0';
requires 'Parse::CPAN::Meta' => '1.4414';
requires 'Parse::CPAN::Packages::Fast' => '0.09';
requires 'Parse::LocalDistribution' => '0.14';
requires 'Path::Tiny' => '0';
requires 'Pod::Usage' => '0';
requires 'Try::Tiny' => '0';
requires 'Type::Tiny' => '2.000000';
requires 'Types::Self' => '0';
requires 'Types::URI' => '0';
requires 'feature' => '0';
requires 'namespace::clean' => '0';
requires 'parent' => '0';
requires 'version' => '0.9912';
};

on 'test' => sub {
requires 'File::Touch';
requires 'File::Which';
requires 'PAUSE::Packages';
requires 'Path::Class';
requires 'Test::More', '0.98';
requires 'Test::RequiresInternet', '0.02';
requires 'File::Touch' => '0';
requires 'File::Which' => '0';
requires 'PAUSE::Packages' => '0';
requires 'Path::Class' => '0';
requires 'Test::More' => '0.98';
requires 'Test::RequiresInternet' => '0.02';
};

on 'develop' => sub {
requires 'Test::MinimumVersion::Fast';
requires 'Test::PAUSE::Permissions';
requires 'Test::Spellunker';
requires 'Test::MinimumVersion::Fast' => '0';
requires 'Test::PAUSE::Permissions' => '0';
requires 'Test::Spellunker' => '0';
};
1 change: 0 additions & 1 deletion lib/OrePAN2.pm
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
package OrePAN2;
use 5.008005;
use strict;
use warnings;

Expand Down
31 changes: 13 additions & 18 deletions lib/OrePAN2/Auditor.pm
Original file line number Diff line number Diff line change
@@ -1,26 +1,22 @@
package OrePAN2::Auditor;

use Moo 1.007000;
use Moo;

use feature qw( say state );
use version 0.9912;
use version;

use Carp qw( croak );
use List::Compare ();
use MooX::Options;
use Parse::CPAN::Packages::Fast 0.09 ();
use Path::Tiny ();
use Type::Params qw( compile );
use Type::Tiny::Enum ();
use Types::Standard qw( ArrayRef Bool InstanceOf Str );
use Type::Params qw( signature );
use Types::Self qw( Self );
use Types::Standard qw( ArrayRef Bool Enum InstanceOf Str );
use Types::URI qw( Uri );
use LWP::UserAgent ();

my $SHOW = Type::Tiny::Enum->new(
name => 'Show',
values =>
[ 'cpan-only-modules', 'darkpan-only-modules', 'outdated-modules' ],
);
use namespace::clean -except => [qw( _options_data _options_config )];

option cpan => (
is => 'ro',
Expand All @@ -41,8 +37,9 @@ option darkpan => (
);

option show => (
is => 'ro',
isa => $SHOW,
is => 'ro',
isa =>
Enum [qw( cpan-only-modules darkpan-only-modules outdated-modules )],
format => 's',
);

Expand Down Expand Up @@ -167,17 +164,15 @@ sub run {
}

sub cpan_module {
my $self = shift;
state $check = compile(Str);
my ($module) = $check->(@_);
state $signature = signature( method => Self, positional => [Str] );
my ( $self, $module ) = $signature->(@_);

return $self->_cpan_parser->package($module);
}

sub darkpan_module {
my $self = shift;
state $check = compile(Str);
my ($module) = $check->(@_);
state $signature = signature( method => Self, positional => [Str] );
my ( $self, $module ) = $signature->(@_);

return $self->_darkpan_parser->package($module);
}
Expand Down
Loading
Loading