technically improvements part 1 #61
Conversation
|
Thanks for this! I'm a bit tied up with the Perl Advent Calendar right now, but this is close to the top of my TODO list. |
| sub new { | ||
| my $class = shift; | ||
| my %args = @_ == 1 ? %{ $_[0] } : @_; | ||
| use namespace::clean; |
There was a problem hiding this comment.
Any reason not to use namespace::autoclean?
There was a problem hiding this comment.
No not really. I am using namespace::clean because the Moo documentation provides examples how to work with it and scrubbing is restricted to anything imported before its use.
|
I'm going to close and re-open this to kick off CI. |
|
I think it would be best to rebase to pull in some CI changes and a small typo fix that created a merge conflict. |
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [perl-actions/install-with-cpm](https://github.com/perl-actions/install-with-cpm) from 1.3 to 1.7. - [Release notes](https://github.com/perl-actions/install-with-cpm/releases) - [Commits](perl-actions/install-with-cpm@v1.3...v1.7) --- updated-dependencies: - dependency-name: perl-actions/install-with-cpm dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
I have done the rebase but I haven's switched from |
|
Any idea how and when we can continue to complete this pull-request is very much appreciated. |
|
The merge conflict looks to be: <<<<<<< master
or Carp::croak("Cannot calcurate MD5 for '$filename'");
$self->data->{$stuff} = +{
=======
or Carp::croak("Cannot calculate MD5 for '$filename'");
$self->{data}->{$stuff} = +{
>>>>>>> masterI think in the context of this PR, we'd want the first one, which is using the |
|
Yes I agree, but I am not able to resolve the conflict because I do not have sufficient access permissions. |
|
Thanks, @XSven. I'm sorry it took this long to get it merged. |
This pull request contains some of the technical improvements that were already communicated to Olaf Alders. Some points I want to highlight:
File::pushdobjects before passing to them torun()method in t/cli/indexer.t. This is the only test script that was changed!CodeRef | Str) ofauthorattribute belonging toOrePAN2::Injectorclass.minil. I have removed META.json from git becauseminil distcreates this automatically.MooandType::Tinyconsistently.Class::Accessor::Liteisn't use anymore.