-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kdenlive #21646
base: master
Are you sure you want to change the base?
kdenlive #21646
Conversation
3176152
to
b4fb74f
Compare
I do not think using separate package for building with cross-compiler is a bad idea. There are a lot of packages like this. You can find a lot of |
I agree that it should be in By the way, this Github actions failed and behave differently than that of my branch. My branch is up-to-date and is still building it (https://github.com/knyipab/termux-packages/actions). I expect it to build successfully. |
Few things to add:
|
9f48e6d
to
388f37e
Compare
Before merging this pull request, we need to figure out how to manage auto-update with a group of packages instead of individual packages. Otherwise, we would get multiple kf6 auto-update issues. For example, we recently get qt6 auto-update issues which would not happen if those packages are updated in a specific order. I can not figure out how to enable auto-update for groups. If anyone will implement that I can try to add the package groups e.g. qt5/6, kf5/6, gstreamer etc. |
388f37e
to
1cb18e6
Compare
A separate I did simple testing on preview, effects and render. Other than the cross tool issue as well as the package group issue mentioned by @Biswa96, this PR should be probably quite ready for review. |
1cb18e6
to
e98bfe2
Compare
If the only thing you need in kf6-kconfig-cross-tools is
So it will be a part of |
8191e84
to
281b1d8
Compare
@twaik Thanks and done making it as a subpackage. |
@knyipab This is unrelated to the current pull request, but in the future, do you think there's a possibility that programs like |
There are some git conflict with recent kf6 changes. Here are two things to follow.
|
@knyipab can you please rebase this PR to master? The branch has conflicts. |
281b1d8
to
19a3dca
Compare
Rebased, bumped to 6.7.0 and modified as requested. |
f936dc2
to
9134ab1
Compare
@TomJo2000 Addressed your code review. Sorry to say that I doubt if it would be helpful to put me as maintainer for this particular package, provided no much expertise involved (unlike xfce plugins last time) and the uncertainty of my activeness (my skill and spare time only allow me to do simple stuff these days). Plus, kf6-* & mlt should likely be reused by other KDE apps frequently in the future. |
Should bring us closer to a complete KDE. Also prove that
qt6-qt5compat
#21573 is working.Some dirty hacks applied onDonekf6-kconfig
to build kdenlive. Help wanted to address such issue, see #21647.Closes #16837