Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log-separator): log separator should always wrap log #364

Merged
merged 3 commits into from
Jul 25, 2023
Merged

fix(log-separator): log separator should always wrap log #364

merged 3 commits into from
Jul 25, 2023

Conversation

YuryShkoda
Copy link
Member

@YuryShkoda YuryShkoda commented Jul 24, 2023 •
edited
Loading

Issue

The response body can contain multiple logs and this is why log should always be wrapped from the beginning and the end.

Intent

  • Improve response body.

Implementation

  • Wrapped log with log separator.

Checks

  • Code is formatted correctly (npm run lint:fix).
  • Any new functionality has been unit tested.
  • All unit tests are passing (npm test).
  • All CI checks are green.
  • Reviewer is assigned.

@YuryShkoda YuryShkoda requested a review from sabhas July 25, 2023 05:53
@YuryShkoda YuryShkoda merged commit 2f47a22 into main Jul 25, 2023
3 checks passed
@YuryShkoda YuryShkoda deleted the log-separator branch July 25, 2023 06:01
@sasjsbot
Copy link

🎉 This PR is included in version 0.35.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@YuryShkoda YuryShkoda mentioned this pull request Jul 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allanbowe allanbowe allanbowe approved these changes

@sabhas sabhas sabhas approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YuryShkoda @sasjsbot @allanbowe @sabhas