feat(sasjs-request-client): improved parseResponse method #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 5f15226 |
medjedovicm
approved these changes
Jul 26, 2023
allanbowe
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Related PR sasjs/server#364.
Intent
@sasjs/adaptershould be able to parse HTTP responses from@sasjs/serverwith nested logs.Implementation
parseResponsemethod ofSasjsRequestClientclass.parseResponsemethod ofSasjsRequestClientclass with unit tests.Checks
No PR (that involves a non-trivial code change) should be merged, unless all items below are confirmed! If an urgent fix is needed - use a tar file.
sasjs-cliunit tests are passing (npm test).sasjs-testsare passing. If you want to run it manually (instructions available here).