Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Physics system (Edifice 5.1) #365

Merged
merged 5 commits into from
Jun 30, 2021
Merged

Align Physics system (Edifice 5.1) #365

merged 5 commits into from
Jun 30, 2021

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Jun 30, 2021 •
edited
Loading

Following the steps listed in #315.

In order to prevent #319, commit 4ede2cf reverts upstream's PR gazebosim/gz-sim#690.

Note: remember to Squash and merge this PR.

@diegoferigo diegoferigo self-assigned this Jun 30, 2021
This was referenced Jun 30, 2021
Merged
Open
@diegoferigo
Copy link
Member Author

diegoferigo commented Jun 30, 2021 •
edited
Loading

This alignment has broken one of the tests #366. Since it is an edge case, I disabled temporarily the test in 4293035.

@diegoferigo diegoferigo merged commit ed3e135 into devel Jun 30, 2021
@diegoferigo diegoferigo deleted the feature/physics_system branch June 30, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@diegoferigo diegoferigo

Labels
complexity::medium component::scenario::plugins pr::resolution::merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diegoferigo @traversaro