Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README example to docs #7446

Closed

Conversation

Krupakar-Reddy-S
Copy link
Contributor

@Krupakar-Reddy-S Krupakar-Reddy-S commented Aug 5, 2024

Description

Added the example from pymc REAME.md to the pymc_overview notebook in learn section of docs as case study 0.

Related Issue

Checklist

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc--7446.org.readthedocs.build/en/7446/

Copy link

welcome bot commented Aug 5, 2024

Thank You Banner]
💖 Thanks for opening this pull request! 💖 The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Adityajaiswal03 Adityajaiswal03 mentioned this pull request Aug 5, 2024
9 tasks
@Krupakar-Reddy-S
Copy link
Contributor Author

image

After updating there are empty bars before output tables, these correspond to weird Output () in the notebook rendered in github.

image

please advice on how to fix this :)

@twiecki
Copy link
Member

twiecki commented Aug 6, 2024

Hm, now looking at this, I'm not sure what this example provides in addition to example 1 (sorry)... @OriolAbril what are your thoughts here?

@twiecki twiecki requested a review from OriolAbril August 6, 2024 10:57
@twiecki
Copy link
Member

twiecki commented Aug 6, 2024

Another idea would be to put that example on the welcome page: https://www.pymc.io/welcome.html

@Krupakar-Reddy-S
Copy link
Contributor Author

Krupakar-Reddy-S commented Aug 6, 2024

Hm, now looking at this, I'm not sure what this example provides in addition to example 1 (sorry)... @OriolAbril what are your thoughts here?

I felt the same as there was a very detailed motivating example before this.
ok then i will put it up on the welcome page.

@twiecki
Copy link
Member

twiecki commented Aug 6, 2024

While we're here, do you want to change the imports at to pt (pytensor)?

@Krupakar-Reddy-S
Copy link
Contributor Author

While we're here, do you want to change the imports at to pt (pytensor)?

Sure :)
Also what version of pymc to use here, i have used 5.15.1 for my previous changes or is there a specific standard for the docs notebooks?

@twiecki
Copy link
Member

twiecki commented Aug 6, 2024

The most recent one ideally but it doesn't matter too much here.

@Krupakar-Reddy-S
Copy link
Contributor Author

I have raised the PR here to add the example to the welcome page.
I will raise for the import name change here :)

@twiecki
Copy link
Member

twiecki commented Aug 8, 2024

Thanks for your patience :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include README example in docs homepage
3 participants