Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added example from README #98

Merged
merged 1 commit into from
Aug 12, 2024
Merged

Conversation

Krupakar-Reddy-S
Copy link
Contributor

@Krupakar-Reddy-S Krupakar-Reddy-S commented Aug 7, 2024

Added the example from pymc REAME to the welcome page at pymc.io.

This is from issue pymc #7411,
previously raised a PR and discussed here.


📚 Documentation preview 📚: https://pymcio--98.org.readthedocs.build/

@Krupakar-Reddy-S
Copy link
Contributor Author

noticed the last column title is not wrapping properly in the build :(

Screenshot 2024-08-07 163105

@twiecki
Copy link
Member

twiecki commented Aug 7, 2024

I like it! CC @OriolAbril

@twiecki twiecki requested a review from OriolAbril August 7, 2024 18:25
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, we removed the other code example because the im browser execution wasn't working well, I like this one

welcome.md Show resolved Hide resolved
@Krupakar-Reddy-S
Copy link
Contributor Author

@twiecki should i make that change?

@twiecki
Copy link
Member

twiecki commented Aug 11, 2024

@twiecki should i make that change?

Yes

@Krupakar-Reddy-S
Copy link
Contributor Author

@twiecki is this good?

image

@twiecki twiecki merged commit dfe5a99 into pymc-devs:main Aug 12, 2024
2 checks passed
@twiecki
Copy link
Member

twiecki commented Aug 12, 2024

Thanks!

@Krupakar-Reddy-S
Copy link
Contributor Author

@twekei i have not made the chnage, i wanted to know how it was before making it :(

@twiecki
Copy link
Member

twiecki commented Aug 12, 2024

Oh, jumped the gun. Just make a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants