New supporting functions for eth-sn-contracts #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using operator= for the LHS means the string is reassigned instead of potentially using available capacity in the pre-existing string. You can use the `insert` or `append` calls to reuse the internal buffer where possible.
Allow returning of the original JSON object which allows the caller avoid a memory allocation and compute cost of automatically converting the JSON to a string. It also the caller to preserve the JSON structure for lookup. Additionally, the caller can get references to the underlying data avoiding additional allocations.
Additionally rename the functions to be the format <A>to<B> which allows parsing of intent from left-to-right.
- Take in string_view where possible to avoid allocations where possible - Since we take string_views, the previous functions used from the standard library only worked with strings/or required cstrings which are null-terminated, hence we have to transform our functions to support length denoted strings as not all string_view's are null-terminated.
Doy-lee
force-pushed
the
new-supporting-functions
branch
from
38aaeb6
to
7cde41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tid-bits and fixes for new functionality in the eth-sn-contracts tests
Provider::callReadFunctionnow thunks intoProvider::callReadFunctionJSON, the latter which returns the originalnlohmann::jsonobject which is more optimal because it allows grabbing theresultstring by reference saving an allocation.addressFromPrivateKeytosecretKeyToAddress[String]and add a version that preserves the binary representation of the address.