Expose service nodes from smart contract #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`reinterpret_cast` from the C structure to the C++ structure is illegal because the original object that the key was instantiated in was not a G1 point. Instead implement the logic in a C++ compliant way using memcpy which allows the construction of types unrelated to each other.
|
Has been merged in via #2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This depends on oxen-io/ethyl#11 being merged.
Added a way to invoke
serviceNodes()andserviceNodeIDs()from the smart contract in C++ meaning we can test the service node data stored on the EVM. Included is various fixes and helper APIs to achieve that.This is just the base functionality and a few supporting tests. More in depth tests can follow but I'd like to checkpoint the work into the mainline branch so everyone's on the same page.