Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add :Z mount to fix local validation errors when using podman #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add :Z mount to fix local validation errors when using podman #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/schema_validation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ yamlList() {
check_validation() {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add error handling to capture potential errors during execution?

  # Ensure the function receives the required parameter
  if [ -z "$1" ]; then
    echo "Error: No YAML files specified."
    return 1
  fi

  local yaml_files="$1"

echo "validating the jsonschema for $yamlFiles"
$CONTAINER_ENGINE run --rm -v $(pwd):$CONTAINER_PATH quay.io/app-sre/managed-scripts:latest /root/.local/bin/check-jsonschema --schemafile $CONTAINER_PATH/hack/metadata.schema.json $yamlFiles
$CONTAINER_ENGINE run --rm -v $(pwd):$CONTAINER_PATH:Z quay.io/app-sre/managed-scripts:latest /root/.local/bin/check-jsonschema --schemafile $CONTAINER_PATH/hack/metadata.schema.json $yamlFiles

}

Expand Down