Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add :Z mount to fix local validation errors when using podman #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaphaelBut
Copy link

not sure if this is the right approach but when calling make validation using podman I get permissions errors.

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: RaphaelBut
Once this PR has been reviewed and has the lgtm label, please assign bmeng for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RaphaelBut
Copy link
Author

I have not tested that this still works with docker

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

@RaphaelBut: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@@ -61,7 +61,7 @@ yamlList() {
check_validation() {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add error handling to capture potential errors during execution?

  # Ensure the function receives the required parameter
  if [ -z "$1" ]; then
    echo "Error: No YAML files specified."
    return 1
  fi

  local yaml_files="$1"

@bmeng
Copy link
Contributor

bmeng commented Aug 7, 2024

Hi @RaphaelBut any update for this PR? Is it still needed?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xiaoyu74
Copy link
Contributor

xiaoyu74 commented Sep 3, 2024

@RaphaelBut - Please rebase the PR to resolve the conflicts. Also, any updates for the PR based on the current review feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants