-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[items] ItemPersistence: Add medianSince, medianUntil and medianBetween methods #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Not sure why the signoff check fails |
florian-h05
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor remark:
(Please regenerate type defs after that change.)
florian-h05
changed the title
[items] itemPersistence: add MedianSince, MedianUntil and MedianBetween methods
[items] ItemPersistence: Add MedianSince, MedianUntil and MedianBetween methods
Aug 26, 2024
florian-h05
changed the title
[items] ItemPersistence: Add MedianSince, MedianUntil and MedianBetween methods
[items] ItemPersistence: Add MedianSince, MmedianUntil and MedianBetween methods
Aug 26, 2024
florian-h05
changed the title
[items] ItemPersistence: Add MedianSince, MmedianUntil and MedianBetween methods
[items] ItemPersistence: Add medianSince, medianUntil and medianBetween methods
Aug 26, 2024
Signed-off-by: Mark Herwege mark.herwege@telenet.be
florian-h05
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
florian-h05
pushed a commit
to openhab/openhab-webui
that referenced
this pull request
Sep 16, 2024
Depends on openhab/openhab-js#376 Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #375
Signed-off-by: Mark Herwege mark.herwege@telenet.be