Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[items] ItemPersistence: Add medianSince, medianUntil and medianBetween methods #376

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Aug 26, 2024

Closes #375

Signed-off-by: Mark Herwege mark.herwege@telenet.be

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner August 26, 2024 07:07
@mherwege
Copy link
Contributor Author

Not sure why the signoff check fails

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor remark:

(Please regenerate type defs after that change.)

src/items/item-persistence.js Outdated Show resolved Hide resolved
@florian-h05 florian-h05 changed the title [items] itemPersistence: add MedianSince, MedianUntil and MedianBetween methods [items] ItemPersistence: Add MedianSince, MedianUntil and MedianBetween methods Aug 26, 2024
@florian-h05 florian-h05 changed the title [items] ItemPersistence: Add MedianSince, MedianUntil and MedianBetween methods [items] ItemPersistence: Add MedianSince, MmedianUntil and MedianBetween methods Aug 26, 2024
@florian-h05 florian-h05 changed the title [items] ItemPersistence: Add MedianSince, MmedianUntil and MedianBetween methods [items] ItemPersistence: Add medianSince, medianUntil and medianBetween methods Aug 26, 2024
@florian-h05 florian-h05 added this to the to be released milestone Aug 26, 2024
@florian-h05 florian-h05 added the enhancement New feature or request label Aug 26, 2024
Signed-off-by: Mark Herwege mark.herwege@telenet.be
Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@florian-h05 florian-h05 merged commit d3898b8 into openhab:main Aug 26, 2024
4 checks passed
@mherwege mherwege deleted the median branch August 26, 2024 16:22
florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Sep 16, 2024
Depends on openhab/openhab-js#376

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[items] ItemPersistence: Add median functions
2 participants