Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blockly] Add persistence median methods #2732

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

mherwege
Copy link
Contributor

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege mherwege requested a review from a team as a code owner August 26, 2024 07:17
Copy link

relativeci bot commented Aug 26, 2024

#2222 Bundle Size — 10.83MiB (~+0.01%).

f92d162(current) vs 5716165 main#2221(baseline)

Warning

Bundle contains 2 duplicate packages – View duplicate packages

Bundle metrics  Change 1 change
                 Current
#2222
     Baseline
#2221
No change  Initial JS 1.89MiB 1.89MiB
No change  Initial CSS 576.5KiB 576.5KiB
Change  Cache Invalidation 17.97% 17.67%
No change  Chunks 226 226
No change  Assets 249 249
No change  Modules 2914 2914
No change  Duplicate Modules 149 149
No change  Duplicate Code 1.8% 1.8%
No change  Packages 96 96
No change  Duplicate Packages 2 2
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2222
     Baseline
#2221
Regression  JS 9.05MiB (~+0.01%) 9.05MiB
No change  CSS 862.92KiB 862.92KiB
No change  Fonts 526.1KiB 526.1KiB
No change  Media 295.6KiB 295.6KiB
No change  IMG 140.74KiB 140.74KiB
No change  HTML 1.35KiB 1.35KiB
No change  Other 871B 871B

Bundle analysis reportBranch mherwege:blockly-medianProject dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@florian-h05 florian-h05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Just FYI this not only depends on the openhab-js PR, but also needs a new openhab-js release and a PR to the add-on to use the new version.

@florian-h05 florian-h05 added enhancement New feature or request main ui Main UI awaiting other PR Depends on another PR labels Aug 26, 2024
@florian-h05 florian-h05 changed the title [Blockly] add persistence median methods [blockly] Add persistence median methods Aug 26, 2024
@florian-h05 florian-h05 removed the awaiting other PR Depends on another PR label Sep 16, 2024
@florian-h05 florian-h05 merged commit 0546412 into openhab:main Sep 16, 2024
8 checks passed
@florian-h05 florian-h05 added this to the 4.3 milestone Sep 16, 2024
@mherwege mherwege deleted the blockly-median branch September 16, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request main ui Main UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants