Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add delivery item service #2398

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

yaraslau-kavaliou
Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou commented Aug 30, 2023

@yaraslau-kavaliou yaraslau-kavaliou force-pushed the feat/add-delivery-item-service branch 2 times, most recently from 7b38453 to 8c1e400 Compare August 30, 2023 16:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (57e9815) 16.72% compared to head (62fe0d7) 16.71%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #2398      +/-   ##
=============================================
- Coverage      16.72%   16.71%   -0.02%     
- Complexity      3178     3182       +4     
=============================================
  Files            206      207       +1     
  Lines          11444    11453       +9     
=============================================
  Hits            1914     1914              
- Misses          9530     9539       +9     
Files Changed Coverage Δ
models/classes/DeliveryItemTypeService.php 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

config/default/DeliveryItemTypeRepository.conf.php Outdated Show resolved Hide resolved
config/default/DeliveryItemTypeRepository.conf.php Outdated Show resolved Hide resolved
models/classes/DeliveryItemTypeRepository.php Outdated Show resolved Hide resolved
Copy link
Collaborator

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a migration that would register DeliveryItemTypeService for environments that are updated, rather than newly installed

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Version

Target Version 47.3.0
Last version 47.2.2

There are 0 BREAKING CHANGE, 2 features, 0 fix

Copy link
Collaborator

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful
  • Changelog is updated according to changes (if applicable)
  • Documentation is updated according to changes (if applicable)

@yaraslau-kavaliou yaraslau-kavaliou merged commit 2a42560 into develop Sep 8, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants