-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add delivery item service #2398
Conversation
7b38453
to
8c1e400
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #2398 +/- ##
=============================================
- Coverage 16.72% 16.71% -0.02%
- Complexity 3178 3182 +4
=============================================
Files 206 207 +1
Lines 11444 11453 +9
=============================================
Hits 1914 1914
- Misses 9530 9539 +9
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
8c1e400
to
c5a036b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a migration that would register DeliveryItemTypeService
for environments that are updated, rather than newly installed
84159b9
to
76a1ac7
Compare
76a1ac7
to
62fe0d7
Compare
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
- Changelog is updated according to changes (if applicable)
- Documentation is updated according to changes (if applicable)
Ticket - https://oat-sa.atlassian.net/browse/REL-1167