Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove outcomeui dependency #197

Merged

Conversation

yaraslau-kavaliou
Copy link
Contributor

@yaraslau-kavaliou yaraslau-kavaliou commented Jun 30, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ad4eaab) 45.73% compared to head (6650b89) 45.73%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop     #197   +/-   ##
==========================================
  Coverage      45.73%   45.73%           
  Complexity       166      166           
==========================================
  Files             20       20           
  Lines            575      575           
==========================================
  Hits             263      263           
  Misses           312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vbyndych vbyndych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: well done! The changes look good to me.

Copy link
Contributor

@augustas augustas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need an updated version dependency bump for oat-sa/extension-tao-testqti

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Version

Target Version 3.10.0
Last version 3.9.1

There are 0 BREAKING CHANGE, 3 features, 0 fix

@yaraslau-kavaliou yaraslau-kavaliou merged commit 50ac88d into develop Sep 8, 2023
4 checks passed
"oat-sa/extension-tao-itemqti" : ">=28.22.0",
"oat-sa/extension-tao-testqti" : ">=41.22.2",
"oat-sa/extension-tao-testqti" : ">=47.2.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this dependency was released as 47.3.0
oat-sa/extension-tao-testqti#2398 (comment)
@yaraslau-kavaliou please be careful with dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants