feat: Delete old assets on test overwrite #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielfs7
reviewed
Jul 6, 2023
gabrielfs7
reviewed
Jul 6, 2023
gabrielfs7
reviewed
Jul 7, 2023
Codecov Report
@@ Coverage Diff @@
## develop #2393 +/- ##
=============================================
+ Coverage 16.71% 16.80% +0.08%
- Complexity 3173 3182 +9
=============================================
Files 206 207 +1
Lines 11433 11463 +30
=============================================
+ Hits 1911 1926 +15
- Misses 9522 9537 +15
|
|
Therefore, it does not seem trivial to add unit tests for the new code unless we do a major refactor of |
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 12, 2023
gabrielfs7
reviewed
Jul 13, 2023
gabrielfs7
requested changes
Jul 13, 2023
gabrielfs7
approved these changes
Jul 21, 2023
There was a problem hiding this comment.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Version
There are 0 BREAKING CHANGE, 4 features, 3 fixes |
|
Released as v47.2.0. |
hectoras
added a commit
that referenced
this pull request
Jul 25, 2023
* feat: Delete old assets on test overwrite * feat: Rename event, trigger event before the deletions * feat: Remove logic to extract media references form this extension * fix: dont delete classes whose label don't match the expected label --------- Co-authored-by: Gabriel Felipe Soares <gabrielfs7@gmail.com>
|
Backported as v47.1.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Jira issue: PISA25-411
When importing a test with the overwrite option, if there are media assets referenced by the items in the test, delete them as well the same way we do for items. If that operation would end up with the former asset classes empty, delete them too.
Related PRs: