Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Delete related resources on QtiTestDeletedEvent #632

Merged
merged 7 commits into from
Jul 25, 2023

Conversation

hectoras
Copy link
Contributor

@hectoras hectoras commented Jul 13, 2023

Associated Jira issue: PISA25-411

  • Allow storing an additional payload array on ItemRemovedEvent.
  • Add a new delete method that triggers an event indicating if related assets are to be deleted after deleting an item.

Related PRs:

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #632 (784ef53) into develop (fc24efd) will increase coverage by 0.72%.
The diff coverage is 33.33%.

@@              Coverage Diff              @@
##             develop     #632      +/-   ##
=============================================
+ Coverage      15.22%   15.95%   +0.72%     
- Complexity       553      558       +5     
=============================================
  Files             49       50       +1     
  Lines           1721     1749      +28     
=============================================
+ Hits             262      279      +17     
- Misses          1459     1470      +11     
Impacted Files Coverage Δ
models/classes/class.ItemsService.php 0.84% <0.00%> (-0.08%) ⬇️
models/classes/Command/DeleteItemCommand.php 100.00% <100.00%> (ø)
models/classes/event/ItemRemovedEvent.php 100.00% <100.00%> (+100.00%) ⬆️

Copy link

@rgomeztao rgomeztao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okey :) nice job

@github-actions
Copy link

Version

Target Version 12.1.0
Last version 12.0.3

There are 0 BREAKING CHANGE, 2 features, 0 fix

Copy link
Contributor

@gabrielfs7 gabrielfs7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • New code is covered by tests (if applicable)
  • Tests are running successfully (old and new ones) on my local machine (if applicable)
  • New code is respecting code style rules
  • New code is respecting best practices
  • New code is not subject to concurrency issues (if applicable)
  • Feature is working correctly on my local machine (if applicable)
  • Acceptance criteria are respected
  • Pull request title and description are meaningful

@hectoras hectoras merged commit b53e506 into develop Jul 25, 2023
4 checks passed
@hectoras hectoras deleted the feat/PISA25-411-delete-old-assets-on-test-overwrite branch July 25, 2023 08:18
@hectoras
Copy link
Contributor Author

Released as v12.1.0.

@hectoras
Copy link
Contributor Author

Backported as v12.0.2.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants