-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Delete related resources on QtiTestDeletedEvent #632
feat: Delete related resources on QtiTestDeletedEvent #632
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #632 +/- ##
=============================================
+ Coverage 15.22% 15.95% +0.72%
- Complexity 553 558 +5
=============================================
Files 49 50 +1
Lines 1721 1749 +28
=============================================
+ Hits 262 279 +17
- Misses 1459 1470 +11
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks okey :) nice job
Version
There are 0 BREAKING CHANGE, 2 features, 0 fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- New code is covered by tests (if applicable)
- Tests are running successfully (old and new ones) on my local machine (if applicable)
- New code is respecting code style rules
- New code is respecting best practices
- New code is not subject to concurrency issues (if applicable)
- Feature is working correctly on my local machine (if applicable)
- Acceptance criteria are respected
- Pull request title and description are meaningful
Released as v12.1.0. |
Backported as v12.0.2.1. |
Associated Jira issue: PISA25-411
ItemRemovedEvent
.delete
method that triggers an event indicating if related assets are to be deleted after deleting an item.Related PRs: