Add RECURRENCE-ID with range parameter. #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jabiertxof
force-pushed
the
fixIssue75
branch
4 times, most recently
from
d4a71f1
to
b09621c
Compare
jabiertxof
force-pushed
the
fixIssue75
branch
from
b09621c
to
bb8dc97
Compare
|
WIP: Need to include rrule |
|
Added test for rdate |
niccokunzmann
requested changes
Sep 18, 2024
There was a problem hiding this comment.
Hi, I request changes but first of all! Cool! This looks really good! Let me know which changes you would like to tackle and which ones not so I can create a PR to your branch for those that you do not like ;)
Also, to close the issue we need more tests, I believe..
|
Ready for review again, thanks for get into! |
|
Thanks for your additions! I will merge this and open another PR with the additional tests.. This does not yet solve the issue but it is really close. |
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RECURRENCE-ID with range parameter.
contribute to #75