More work on THISANDFUTURE #182
Merged
+1,075
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also improves the query range extension to front and back for the RRULE
|
This also tests and adds moving and duration of events if they are preceded by an event with RANGE=THISANDFUTURE. |
|
@jabiertxof Thanks for the work so far. This is another PR on the topic and I think, we will have covered most of what is expected by the RFC with this. Once merged, a new release can be drafted. Would you like to have a look on this and see if I forgot something? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jabiertxof, thanks for your PR #181! Instead of getting stuck on details, I just add my flavor on top... I think that makes for a faster cooperation!
Thanks for the work so far... Here I add more tests and move some code.
I.e. I would not do
isinstanceortype(...) == ...checks on custom classes. the dispatch belongs into the class definition (polymorphy)