Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team view button #551

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

xyfer17
Copy link
Contributor

@xyfer17 xyfer17 commented Sep 26, 2024

Linked Issue(s)

#540

Acceptance Criteria fulfillment

  • Add a team view button that redirects to the dora-page, showing dora-data of the team

Proposed changes (including videos or screenshots)

Screen.Recording.2024-09-27.at.12.19.36.AM.mov

Further comments

As per the issue #540, add the tiny-pill button named dora which redirect dora page, showing dora-data of the team

@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024

CLA assistant check
All committers have signed the CLA.

@xyfer17
Copy link
Contributor Author

xyfer17 commented Sep 26, 2024

Hey @e-for-eshaan

Can you Please take a look ?
Thanks :)

@xyfer17 xyfer17 marked this pull request as draft September 30, 2024 03:44
@xyfer17 xyfer17 marked this pull request as ready for review September 30, 2024 03:44
@xyfer17 xyfer17 marked this pull request as draft September 30, 2024 03:44
@xyfer17 xyfer17 marked this pull request as ready for review September 30, 2024 03:45
@jayantbh
Copy link
Contributor

jayantbh commented Oct 1, 2024

Functionally it's there, but visually it leaves some room to be improved.
Suggestions on how we can improve this visually?
@xyfer17 @e-for-eshaan

@xyfer17
Copy link
Contributor Author

xyfer17 commented Oct 2, 2024

@jayantbh could you please suggest any ui change make it's visual look better ?

@jayantbh
Copy link
Contributor

jayantbh commented Oct 2, 2024

We'll share our shot at the visual changes soon.
Meanwhile, could you ensure the linter has run correctly? The CI caught some linting issues.

@xyfer17
Copy link
Contributor Author

xyfer17 commented Oct 3, 2024

We'll share our shot at the visual changes soon. Meanwhile, could you ensure the linter has run correctly? The CI caught some linting issues.

@jayantbh I've fixed the linting issues.

@jayantbh
Copy link
Contributor

Hey @xyfer17, apologies for the silence on this.
SVG:

Please use this logo/icon instead of the button in its current form.

Basically, make it so that it looks and behaves like the other icon buttons:
image

And clicking on it should do the same thing that it does today.

@xyfer17
Copy link
Contributor Author

xyfer17 commented Oct 15, 2024

sure I'll do it and let you know after the change.

@jayantbh jayantbh merged commit abb75b1 into middlewarehq:main Oct 16, 2024
2 of 3 checks passed
@xyfer17 xyfer17 deleted the feature/team-view branch October 16, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants