chore: remove the bff-sdk directory & add the command gql-sdk-upgrade to the Makefile #291
Conversation
Makefile
Outdated
| @@ -254,6 +254,10 @@ gql-gen: | |||
| build-graphql-server: gql-gen | |||
| @CGO_ENABLED=0 GOOS=linux go build -o bin/graphql-server graphql-server/go-server/main.go | |||
|
|
|||
| # sdk for graphql-server api | |||
| gql-sdk-upgrade: | |||
| docker run -v $(shell pwd)/graphql-server/go-server/graph/schema:/schema 172.22.96.34/dev-branch/arcadia-bff-sdk:main | |||
There was a problem hiding this comment.
Perhaps we should push the image 172.22.96.34/dev-branch/arcadia-bff-sdk:main to dockerhub. @bjwswang @Abirdcfly
There was a problem hiding this comment.
Taking it a step further, should we make the make gql-sdk-upgrade command auto-triggered to automatically run in github action as soon as some files change?
There was a problem hiding this comment.
1st. Never tag/use image with a internal image registry. Cause we are opensourced project!
2nd. yes. Make this a github action and triggered automatically. The generated sdk should be published to a publish npm registry.
There was a problem hiding this comment.
- Using the image
kubebb/gql-sdk-generator:main - Put the Github action on my to do list, I need to learn how to write the workflow.
|
Usage: If you have made changes to any *.gql files, you need to follow the steps below before pushing the commit.
|
chore: remove the bff-sdk directory & add the command gql-sdk-upgrade to the Makefile
What type of PR is this?
/kind cleanup
/kind flake
What this PR does / why we need it
remove the bff-sdk directory & add the command gql-sdk-upgrade to the Makefile. automatically upgrade the SDK version.
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer