-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add CRD Application #197
Conversation
484e6ff
to
e7c4b35
Compare
7bd7d80
to
290ce34
Compare
19b4dcc
to
c823359
Compare
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
return app, ctrl.Result{}, nil | ||
} | ||
} | ||
toOutputNodeNext = len(node.NextNodeName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe combine this two for _,node := range app.Spec.Nodes
together ?
// 7. should not have cycle TODO | ||
// 8. nodeName should be unique | ||
func (r *ApplicationReconciler) validateNodes(ctx context.Context, log logr.Logger, app *arcadiav1alpha1.Application) (*arcadiav1alpha1.Application, ctrl.Result, error) { | ||
var input, output int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a strict rule for app developers. We need a document later.
limitations under the License. | ||
*/ | ||
|
||
package zhipuai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greate! #79 This issue can be closed as well. Right ? @Abirdcfly
"github.com/kubeagi/arcadia/pkg/llms/zhipuai" | ||
) | ||
|
||
var _ llms.LLM = (*ZhipuLLM)(nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since our worker provides openai-compatible apis , we need to support openai llm ASAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abirdcfly Nice job!
We need to support
knowledgebase
as a nodeopenai
as a llm
Then we shall have a complete llmops! ⭐
track remaining issue using #308 |
feat: add CRD Application
What type of PR is this?
/kind feature
What this PR does / why we need it
Which issue(s) this PR fixes
Fixes #132
Special notes for your reviewer
https://shimo.im/docs/vVqRM4yWXWUXlj3y
source: https://github.com/Abirdcfly/llm-examples/blob/main/chatbot.py
online url: http://172.22.96.167:8502/