Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the tests broken in 6.3 since 6.4 is already out and fixed the issue #234

Merged
merged 1 commit into from
Nov 4, 2023
Merged

Add back the tests broken in 6.3 since 6.4 is already out and fixed the issue #234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/test_channels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,6 @@ def test_channels_online(logged_rocket):
assert len(channels_online.get("online")) >= 1


@pytest.mark.skip(reason="Broken in 6.3")
def test_channels_set_default(logged_rocket):
channels_set_default = logged_rocket.channels_set_default(
room_id="GENERAL", default=False
Expand Down
5 changes: 0 additions & 5 deletions tests/test_integrations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def integrations_create_webhook_incoming(logged_rocket):
).json()


@pytest.mark.skip(reason="Broken in 6.3")
def test_integrations_create(integrations_create_webhook_incoming, logged_rocket):
integration_webhook_incoming = integrations_create_webhook_incoming
assert integration_webhook_incoming.get("success")
Expand All @@ -39,13 +38,11 @@ def test_integrations_create(integrations_create_webhook_incoming, logged_rocket
assert integration_webhook_outgoing.get("success")


@pytest.mark.skip(reason="Broken in 6.3")
def test_integrations_get(integrations_create_webhook_incoming, logged_rocket):
integration_id = integrations_create_webhook_incoming.get("integration").get("_id")
assert logged_rocket.integrations_get(integration_id).json().get("success")


@pytest.mark.skip(reason="Broken in 6.3")
def test_integrations_history(integrations_create_webhook_incoming, logged_rocket):
integration_id = integrations_create_webhook_incoming.get("integration").get("_id")
assert logged_rocket.integrations_history(integration_id).json().get("success")
Expand All @@ -55,7 +52,6 @@ def test_integrations_list(logged_rocket):
assert logged_rocket.integrations_list().json().get("success")


@pytest.mark.skip(reason="Broken in 6.3")
def test_integrations_remove(integrations_create_webhook_incoming, logged_rocket):
integration = integrations_create_webhook_incoming.get("integration")
assert (
Expand All @@ -67,7 +63,6 @@ def test_integrations_remove(integrations_create_webhook_incoming, logged_rocket
)


@pytest.mark.skip(reason="Broken in 6.3")
def test_integrations_update(integrations_create_webhook_incoming, logged_rocket):
integration_id = integrations_create_webhook_incoming.get("integration").get("_id")
assert (
Expand Down