Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the tests broken in 6.3 since 6.4 is already out and fixed the issue #234

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

jadolg
Copy link
Owner

@jadolg jadolg commented Nov 4, 2023

No description provided.

Copy link

sonarcloud bot commented Nov 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (794d4a8) 96.15% compared to head (0866308) 97.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   96.15%   97.77%   +1.61%     
==========================================
  Files          41       41              
  Lines        1666     1660       -6     
  Branches      137      131       -6     
==========================================
+ Hits         1602     1623      +21     
+ Misses         58       30      -28     
- Partials        6        7       +1     
Files Coverage Δ
tests/test_channels.py 100.00% <ø> (+2.31%) ⬆️
tests/test_integrations.py 100.00% <ø> (+35.29%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jadolg jadolg merged commit efccf24 into master Nov 4, 2023
14 checks passed
@jadolg jadolg deleted the add-6.3-broken-tests-back branch November 4, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant