Updated multiple examples and validated updates #47
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
For examples\gcp-rhel-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED.
For examples\gcp-windows-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED.
For examples\gcp-windows-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED.
For examples\gcp-linux-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED.
PR Type
enhancement
Description
recommendedType
from "c3-standard-4" to "c4-standard-4" in multiple files across different examples to reflect new recommendations.versions.tf
files fromgcp-rhel-vm
andgcp-windows-vm
examples to resolve version conflicts with the rootversions.tf
.Changes walkthrough 📝
variables.tf
Update recommended VM type in variables.tf
examples/gcp-linux-vm-ico-by-densify/variables.tf
recommendedType
from "c3-standard-4" to "c4-standard-4".variables.tf
Update recommended VM type in variables.tf
examples/gcp-windows-vm-ico-by-densify/variables.tf
recommendedType
from "c3-standard-4" to "c4-standard-4".densify_recommendations.auto.tfvars
Update recommended VM type in auto.tfvars
examples/gcp-linux-vm-ico-by-densify/densify_recommendations.auto.tfvars
recommendedType
from "c3-standard-4" to "c4-standard-4".densify_recommendations.auto.tfvars
Update recommended VM type in auto.tfvars
examples/gcp-windows-vm-ico-by-densify/densify_recommendations.auto.tfvars
recommendedType
from "c3-standard-4" to "c4-standard-4".versions.tf
Remove conflicting local versions.tf file
examples/gcp-rhel-vm/versions.tf
versions.tf
file to resolve version conflicts.versions.tf
Remove conflicting local versions.tf file
examples/gcp-windows-vm/versions.tf
versions.tf
file to resolve version conflicts.README.md
Update recommended VM type in README.md
examples/gcp-linux-vm-ico-by-densify/README.md
recommendedType
from "c3-standard-4" to "c4-standard-4".README.md
Update recommended VM type in README.md
examples/gcp-windows-vm-ico-by-densify/README.md
recommendedType
from "c3-standard-4" to "c4-standard-4".