Skip to content

Commit

Permalink
Updated multiple examples and validated updates (#47)
Browse files Browse the repository at this point in the history
For examples\gcp-rhel-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED.

For examples\gcp-windows-vm: Had to remove local versions.tf due to conflict of older version with root\version.tf thus just deleted the local versions.tf as it is not needed. After this was done - example VALIDATED.

For examples\gcp-windows-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED.

For examples\gcp-linux-vm-ico-by-densify: variables.tf needed to be modified to set recommendedType = "c4-standard-4"- these changes were also don on readme.md, densify_recommendation.auto.tvars files - VALIDATED.
  • Loading branch information
daveshrestha-intel authored Oct 9, 2024
1 parent e6f8004 commit ce33534
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 30 deletions.
4 changes: 2 additions & 2 deletions examples/gcp-linux-vm-ico-by-densify/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ variable "densify_recommendations" {
default = {
ico-test = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "26.6"
predictedUptime = "94.32"
Expand All @@ -62,7 +62,7 @@ variable "densify_fallback"{
type = map(string)
default = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "0"
predictedUptime = "0"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
densify_recommendations = {
"ico-test" = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
predictedUptime = "95.0"
recommendationType = "Modernize"
Expand Down
4 changes: 2 additions & 2 deletions examples/gcp-linux-vm-ico-by-densify/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ variable "densify_recommendations" {
default = {
ico-test = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "26.6"
predictedUptime = "94.32"
Expand All @@ -30,7 +30,7 @@ variable "densify_fallback"{
type = map(string)
default = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "0"
predictedUptime = "0"
Expand Down
10 changes: 0 additions & 10 deletions examples/gcp-rhel-vm/versions.tf

This file was deleted.

4 changes: 2 additions & 2 deletions examples/gcp-windows-vm-ico-by-densify/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ variable "densify_recommendations" {
default = {
ico-test = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "26.6"
predictedUptime = "94.32"
Expand All @@ -61,7 +61,7 @@ variable "densify_fallback"{
type = map(string)
default = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "0"
predictedUptime = "0"
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
densify_recommendations = {
"ico-test" = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
predictedUptime = "95.0"
recommendationType = "Modernize"
Expand Down
4 changes: 2 additions & 2 deletions examples/gcp-windows-vm-ico-by-densify/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ variable "densify_recommendations" {
default = {
ico-test = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "26.6"
predictedUptime = "94.32"
Expand All @@ -30,7 +30,7 @@ variable "densify_fallback"{
type = map(string)
default = {
currentType = "n1-standard-2"
recommendedType = "c3-standard-4"
recommendedType = "c4-standard-4"
approvalType = "all"
savingsEstimate = "0"
predictedUptime = "0"
Expand Down
10 changes: 0 additions & 10 deletions examples/gcp-windows-vm/versions.tf

This file was deleted.

0 comments on commit ce33534

Please sign in to comment.