Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pak install and add to minicran for further availability checks #3

Closed
wants to merge 4 commits into from

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Aug 30, 2024

alternative to #2

Main changes:

  • use pak for installing
    • this will respect Remotes for non-CRAN dependent packages
    • for the package itself - try to derive GitHub ref for released version based on URL field from the DESCRIPTION file
  • after pak install - look in the pkgcache and copy .tar.gz into miniCRAN so that it's findable by revdepcheck and anyone else

Fixes:

  • printing empty report

@pawelru
Copy link
Contributor Author

pawelru commented Sep 2, 2024

I have read the CLA Document and I hereby sign the CLA

@m7pr
Copy link
Contributor

m7pr commented Sep 2, 2024

recheck

@m7pr
Copy link
Contributor

m7pr commented Sep 2, 2024

CLA assistant failed with below issue

Error: Could not retrieve repository contents. Status: 404

https://github.com/insightsengineering/r-revdepcheck-action/actions/runs/10663392597/job/29552480818#step:2:21

@cicdguy would you know what is the source of the problem?

image

@cicdguy
Copy link

cicdguy commented Sep 2, 2024

CLA assistant failed with below issue

Error: Could not retrieve repository contents. Status: 404

https://github.com/insightsengineering/r-revdepcheck-action/actions/runs/10663392597/job/29552480818#step:2:21

@cicdguy would you know what is the source of the problem?

image

Known issue. Tagged you in relevant thread in chat. Feel free to ignore for now.

@m7pr
Copy link
Contributor

m7pr commented Sep 20, 2024

Hey, once this is finalized and merged, please check if those 2 PR fix pipelines in

@walkowif
Copy link
Contributor

@m7pr I ran the revdepcheck workflow, and the results are as follows:

Feel free to re-trigger this workflow (after adding any updates to insightsengineering/r-revdepcheck-action@fix_non_cran) by going here -> Run workflow -> Use workflow from: fix-pipelines@main -> Drop down: revdepcheck (similarly for teal.osprey).

After the testing is done, you can remove my commits from the PRs in teal.goshawk and teal.osprey.

@m7pr
Copy link
Contributor

m7pr commented Sep 20, 2024

One workflow can't find package goshawk and the other can't find package osprey. So I guess this is still not done

@pawelru pawelru mentioned this pull request Sep 25, 2024
@pawelru pawelru closed this Oct 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants