Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non cran2 #4

Merged
merged 17 commits into from
Oct 2, 2024
Merged

Fix non cran2 #4

merged 17 commits into from
Oct 2, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Sep 25, 2024

alternative to: #3

test those two together:

This would require additional inputs: lookup-refs action parameter. I think that this is ok since we have to have an information where to find non-cran dependencies. The Remotes field (if provided) will be used instead of this.
See: insightsengineering/teal.goshawk@main...refs/heads/fix_non_cran2 as an example

Tests:

@pawelru
Copy link
Contributor Author

pawelru commented Sep 25, 2024

I have read the CLA Document and I hereby sign the CLA

@m7pr m7pr self-assigned this Oct 1, 2024
script.R Outdated Show resolved Hide resolved
script.R Outdated Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Outdated Show resolved Hide resolved
script.R Outdated Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
script.R Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to run locally and it looks solid. I left a couple minor comments but this is ready to go and solves the issue of missing packages that were only released on GitHub.

In the future we can consider how to extend this to get packages from GitLab or custom urls, but now it satisfies the need of this GitHub Action and our setup.

── CHECK ────────────────────────────────────────── 0 packages ──
OK: 0
BROKEN: 0
Total time: <1 min
── REPORT ───────────────────────────────────────────────────────
Writing summary to 'revdep/README.md'
Writing problems to 'revdep/problems.md'
Writing failures to 'revdep/failures.md'
Writing CRAN report to 'revdep/cran.md'

> cli::cli_h2("revdep/problems.md")
── revdep/problems.md ──

> catnl(readLines("revdep/problems.md", warn = FALSE))
*Wow, no problems at all. :)*
> cli::cli_h2("revdep/failures.md")
── revdep/failures.md ──

> catnl(readLines("revdep/failures.md", warn = FALSE))
*Wow, no problems at all. :)*
> cli::cli_h2("revdep/cran.md")
── revdep/cran.md ──



# Platform
 
 |field    |value                                      |
 |:--------|:------------------------------------------|
 |version  |R version 4.4.0 (2024-04-24 ucrt)          |
 |os       |Windows 11 x64 (build 22621)               |
 |system   |x86_64, mingw32                            |
 |ui       |RStudio                                    |
 |language |(EN)                                       |
 |collate  |English_Europe.utf8                        |
 |ctype    |English_Europe.utf8                        |
 |tz       |Europe/Berlin                              |
 |date     |2024-10-02                                 |
 |rstudio  |2023.06.1+524 Mountain Hydrangea (desktop) |
 |pandoc   |NA                                         |
 
 # Dependencies
 
 |package           |old      |new        |Δ  |
 |:-----------------|:--------|:----------|:--|
 |teal.goshawk      |0.2.0    |0.2.0.9006 |*  |
 |askpass           |1.2.0    |1.2.0      |   |
 |backports         |1.5.0    |1.5.0      |   |
 |base64enc         |0.1-3    |0.1-3      |   |
 |bslib             |0.8.0    |0.8.0      |   |
 |cachem            |1.1.0    |1.1.0      |   |
 |checkmate         |2.3.2    |2.3.2      |   |
 |cli               |3.6.3    |3.6.3      |   |
 |colorspace        |2.1-1    |2.1-1      |   |
 |colourpicker      |1.3.0    |1.3.0      |   |
 |commonmark        |1.9.1    |1.9.1      |   |
 |cowplot           |1.1.3    |1.1.3      |   |
 |cpp11             |0.5.0    |0.5.0      |   |
 |crayon            |1.5.3    |1.5.3      |   |
 |crosstalk         |1.2.1    |1.2.1      |   |
 |curl              |5.2.3    |5.2.3      |   |
 |data.table        |1.16.0   |1.16.0     |   |
 |digest            |0.6.37   |0.6.37     |   |
 |dplyr             |1.1.4    |1.1.4      |   |
 |DT                |0.33     |0.33       |   |
 |evaluate          |1.0.0    |1.0.0      |   |
 |fansi             |1.0.6    |1.0.6      |   |
 |farver            |2.1.2    |2.1.2      |   |
 |fastmap           |1.2.0    |1.2.0      |   |
 |flextable         |0.9.6    |0.9.6      |   |
 |fontawesome       |0.5.2    |0.5.2      |   |
 |fontBitstreamVera |0.1.1    |0.1.1      |   |
 |fontLiberation    |0.1.0    |0.1.0      |   |
 |fontquiver        |0.2.1    |0.2.1      |   |
 |formatters        |0.5.9    |0.5.9      |   |
 |fs                |1.6.4    |1.6.4      |   |
 |gdtools           |0.4.0    |0.4.0      |   |
 |generics          |0.1.3    |0.1.3      |   |
 |ggnewscale        |0.5.0    |0.5.0      |   |
 |ggplot2           |3.5.1    |3.5.1      |   |
 |glue              |1.8.0    |1.8.0      |   |
 |goshawk           |0.1.18   |0.1.18     |   |
 |gtable            |0.3.5    |0.3.5      |   |
 |highr             |0.11     |0.11       |   |
 |htmltools         |0.5.8.1  |0.5.8.1    |   |
 |htmlwidgets       |1.6.4    |1.6.4      |   |
 |httpuv            |1.6.15   |1.6.15     |   |
 |httr              |1.4.7    |1.4.7      |   |
 |isoband           |0.2.7    |0.2.7      |   |
 |jquerylib         |0.1.4    |0.1.4      |   |
 |jsonlite          |1.8.9    |1.8.9      |   |
 |knitr             |1.48     |1.48       |   |
 |labeling          |0.4.3    |0.4.3      |   |
 |later             |1.3.2    |1.3.2      |   |
 |lazyeval          |0.2.2    |0.2.2      |   |
 |lifecycle         |1.0.4    |1.0.4      |   |
 |logger            |0.3.0    |0.3.0      |   |
 |magrittr          |2.0.3    |2.0.3      |   |
 |mcr               |1.3.3.1  |1.3.3.1    |   |
 |memoise           |2.0.1    |2.0.1      |   |
 |mime              |0.12     |0.12       |   |
 |miniUI            |0.1.1.1  |0.1.1.1    |   |
 |munsell           |0.5.1    |0.5.1      |   |
 |officer           |0.6.6    |0.6.6      |   |
 |openssl           |2.2.2    |2.2.2      |   |
 |pillar            |1.9.0    |1.9.0      |   |
 |pkgconfig         |2.0.3    |2.0.3      |   |
 |plotly            |4.10.4   |4.10.4     |   |
 |promises          |1.3.0    |1.3.0      |   |
 |purrr             |1.0.2    |1.0.2      |   |
 |R.cache           |0.16.0   |0.16.0     |   |
 |R.methodsS3       |1.8.2    |1.8.2      |   |
 |R.oo              |1.26.0   |1.26.0     |   |
 |R.utils           |2.12.3   |2.12.3     |   |
 |R6                |2.5.1    |2.5.1      |   |
 |ragg              |1.3.3    |1.3.3      |   |
 |rappdirs          |0.3.3    |0.3.3      |   |
 |RColorBrewer      |1.1-3    |1.1-3      |   |
 |Rcpp              |1.0.13   |1.0.13     |   |
 |RcppArmadillo     |14.0.2-1 |14.0.2-1   |   |
 |rlang             |1.1.4    |1.1.4      |   |
 |rmarkdown         |2.28     |2.28       |   |
 |robslopes         |1.1.3    |1.1.3      |   |
 |rprojroot         |2.0.4    |2.0.4      |   |
 |rtables           |0.6.10   |0.6.10     |   |
 |sass              |0.4.9    |0.4.9      |   |
 |scales            |1.3.0    |1.3.0      |   |
 |shiny             |1.9.1    |1.9.1      |   |
 |shinybusy         |0.3.3    |0.3.3      |   |
 |shinycssloaders   |1.1.0    |1.1.0      |   |
 |shinyjs           |2.1.0    |2.1.0      |   |
 |shinyvalidate     |0.1.3    |0.1.3      |   |
 |shinyWidgets      |0.8.7    |0.8.7      |   |
 |sourcetools       |0.1.7-1  |0.1.7-1    |   |
 |stringi           |1.8.4    |1.8.4      |   |
 |stringr           |1.5.1    |1.5.1      |   |
 |styler            |1.10.3   |1.10.3     |   |
 |sys               |3.4.2    |3.4.2      |   |
 |systemfonts       |1.1.0    |1.1.0      |   |
 |teal              |0.15.2   |0.15.2     |   |
 |teal.code         |0.5.0    |0.5.0      |   |
 |teal.data         |0.6.0    |0.6.0      |   |
 |teal.logger       |0.2.0    |0.2.0      |   |
 |teal.reporter     |0.3.1    |0.3.1      |   |
 |teal.slice        |0.5.1    |0.5.1      |   |
 |teal.transform    |0.5.0    |0.5.0      |   |
 |teal.widgets      |0.4.2    |0.4.2      |   |
 |textshaping       |0.4.0    |0.4.0      |   |
 |tibble            |3.2.1    |3.2.1      |   |
 |tidyr             |1.3.1    |1.3.1      |   |
 |tidyselect        |1.2.1    |1.2.1      |   |
 |tinytex           |0.53     |0.53       |   |
 |utf8              |1.2.4    |1.2.4      |   |
 |uuid              |1.2-1    |1.2-1      |   |
 |vctrs             |0.6.5    |0.6.5      |   |
 |viridisLite       |0.4.2    |0.4.2      |   |
 |withr             |3.0.1    |3.0.1      |   |
 |xfun              |0.47     |0.47       |   |
 |xml2              |1.3.6    |1.3.6      |   |
 |xtable            |1.8-4    |1.8-4      |   |
 |yaml              |2.3.10   |2.3.10     |   |
 |zip               |2.3.1    |2.3.1      |   |
```

pawelru and others added 2 commits October 2, 2024 14:02
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
pawelru and others added 5 commits October 2, 2024 14:04
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
Co-authored-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Pawel Rucki <12943682+pawelru@users.noreply.github.com>
@pawelru pawelru merged commit c368cd4 into main Oct 2, 2024
3 of 4 checks passed
@pawelru pawelru deleted the fix_non_cran2 branch October 2, 2024 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants