Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support pelias synonyms file #547

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Support pelias synonyms file #547

merged 2 commits into from
Jul 13, 2023

Conversation

miles-grant-ibigroup
Copy link
Contributor

@miles-grant-ibigroup miles-grant-ibigroup commented Jun 30, 2023 •
edited
Loading

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JavaDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing
  • The description lists all relevant PRs included in this release (remove this if not merging to master)
  • e2e tests are all passing (remove this if not merging to master)

Description

This PR adds support for datatools to keep track of a Pelias custom_name.txt file.

At the moment, we are storing it as a string.

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Jun 30, 2023
This was referenced Jul 3, 2023
Merged
Merged
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review July 12, 2023 11:38
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short and sweet!

JymDyerIBI
JymDyerIBI approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@JymDyerIBI JymDyerIBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@miles-grant-ibigroup miles-grant-ibigroup merged commit 78668f2 into dev Jul 13, 2023
6 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the pelias-synonyms branch July 13, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

@JymDyerIBI JymDyerIBI JymDyerIBI approved these changes

Assignees

@JymDyerIBI JymDyerIBI

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miles-grant-ibigroup @binh-dam-ibigroup @JymDyerIBI