Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Pelias Synonyms File #12

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Conversation

miles-grant-ibigroup
Copy link
Collaborator

Along with ibi-group/datatools-server#547 and ibi-group/datatools-ui#963, this PR adds support for a new part of the webhook request, a Pelias custom_name.txt file. This file is then inserted into the pelias config directory.

This seems to work in most cases, although I'm still testing a few potential environments that cause problems

@miles-grant-ibigroup miles-grant-ibigroup self-assigned this Jul 5, 2023
@miles-grant-ibigroup miles-grant-ibigroup marked this pull request as ready for review July 13, 2023 13:23
Copy link
Collaborator

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clarify the "File created" console log?

Copy link

@philip-cline philip-cline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miles-grant-ibigroup miles-grant-ibigroup merged commit 137d78a into master Aug 9, 2023
1 check passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the custom-name-txt-support branch August 9, 2023 15:09
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

🎉 This PR is included in version 2.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants