Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Limits to required labels when querying for App #856

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Limits to required labels when querying for App #856

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13b8f5f
Limits to required labels when querying for App
cyriltovena Jul 13, 2023
19c6238
yarn format
cyriltovena Jul 13, 2023
89eb29f
Add back missing labels
cyriltovena Jul 13, 2023
712dbeb
support old version
cyriltovena Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/app/overrides/services/apps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,11 @@ function removeDuplicateApps(app: App[]) {
export async function fetchApps(): Promise<
Result<App[], RequestError | ZodError>
> {
// TODO: is this the best query?
const response = await requestWithOrgID('/querier.v1.QuerierService/Series', {
method: 'POST',
body: JSON.stringify({
matchers: [],
labelNames: [PyroscopeAppLabel, ServiceNameLabel, '__profile_type__'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fear we might also need to have some compatibility with older versions of the API.

When you give unknown fields that happens:

HTTP2/400
{
  "code": "invalid_argument",
  "message": "unmarshal into *querierv1.SeriesRequest: proto: (line 1:2): unknown field \"xxxlabel_names\""
}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ho that sux

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not too sure maybe something we can change in connect-go

}),
headers: {
'content-type': 'application/json',
Expand Down
Loading