Limits to required labels when querying for App #856
Conversation
| const response = await requestWithOrgID('/querier.v1.QuerierService/Series', { | ||
| method: 'POST', | ||
| body: JSON.stringify({ | ||
| matchers: [], | ||
| labelNames: [PyroscopeAppLabel, ServiceNameLabel, '__profile_type__'], |
There was a problem hiding this comment.
I fear we might also need to have some compatibility with older versions of the API.
When you give unknown fields that happens:
HTTP2/400
{
"code": "invalid_argument",
"message": "unmarshal into *querierv1.SeriesRequest: proto: (line 1:2): unknown field \"xxxlabel_names\""
}
There was a problem hiding this comment.
not too sure maybe something we can change in connect-go
|
It works for both, looking at adding service reflection and next time we should bump the service version for that type of change
|
* Limits to required labels when querying for App * yarn format * Add back missing labels * support old version
No description provided.