feat(queryExpressions): add buildBaseQueryExpression to create the base LogQL expression
#311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtk-grafana
reviewed
May 7, 2024
gtk-grafana
reviewed
May 13, 2024
| return `sum by (${field}) (count_over_time(${LOG_STREAM_SELECTOR_EXPR} | drop __error__ | ${field}!="" [$__auto]))`; | ||
| return `sum by (${field}) (count_over_time(${buildBaseQueryExpression( | ||
| sceneObject | ||
| )} | drop __error__ | ${field}!="" [$__auto]))`; |
There was a problem hiding this comment.
do we need excess whitespace anymore?
|
Summarizing our slack thread: Sven mentioned we might be able to fix this with _variableDependency on the scene classes. |
thanks galen. I'll continue to look into that. |
svennergr
force-pushed
the
svennergr/query-expressions
branch
from
ead7e4d
to
87ffc87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildBaseQueryExpressionwill create the basic LogQL expression instead of relying on AdhocFilters to do the trick. This allows to more easily adapt expressions where needed.The PR also renames the
VAR_FILTERStoVAR_LABELSto make it clear that that variable stores all indexed labels.Additional side effect: this fixes the "Go to Explore" button, that did not include
| logfmtin some cases.Fixes #257